Bug 19126 - Fix Members.t with IndependentBranches set
Summary: Fix Members.t with IndependentBranches set
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Test Suite (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Marcel de Rooy
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-08-16 11:11 UTC by Marcel de Rooy
Modified: 2019-10-14 19:56 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Bug 19126: Fix Members.t with IndependentBranches set (1.59 KB, patch)
2017-08-16 11:23 UTC, Marcel de Rooy 		Details | Diff | Splinter Review
[SIGNED-OFF] Bug 19126: Fix Members.t with IndependentBranches set (1.57 KB, patch)
2017-08-20 23:53 UTC, Aleisha Amohia 		Details | Diff | Splinter Review
Bug 19126: Fix Members.t with IndependentBranches set (1.63 KB, patch)
2017-08-25 15:16 UTC, Jonathan Druart 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Marcel de Rooy 2017-08-16 11:11:26 UTC 
The results of GetBorrowersToExpunge depend on the state of pref IndependentBranches. Members.t does not respect that.
Comment 1 Marcel de Rooy 2017-08-16 11:23:13 UTC 
Created attachment 66064 [details] [review]
Bug 19126: Fix Members.t with IndependentBranches set

If you enabled that pref, Members.t fails with:
t/db_dependent/Members.t .. 63/63 # Looks like you failed 15 tests of 63.

The first one is:
t/db_dependent/Members.t .. 32/63
   Failed test 'Staff patron not deleted from list'
   at t/db_dependent/Members.t line 304.

Bottle neck is GetBorrowersToExpunge. The results of that sub depend on the
state of this preference.
Trivially fixing it here by disabling the pref before the first call.

Test plan:
[1] Do not apply this patch yet. Enable IndependentBranches.
[2] Run Members.t and observe that it fails.
[3] Apply this patch. And run Members.t again. It should pass now.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 2 Aleisha Amohia 2017-08-20 23:53:13 UTC 
Created attachment 66259 [details] [review]
[SIGNED-OFF] Bug 19126: Fix Members.t with IndependentBranches set

If you enabled that pref, Members.t fails with:
t/db_dependent/Members.t .. 63/63 # Looks like you failed 15 tests of 63.

The first one is:
t/db_dependent/Members.t .. 32/63
   Failed test 'Staff patron not deleted from list'
   at t/db_dependent/Members.t line 304.

Bottle neck is GetBorrowersToExpunge. The results of that sub depend on the
state of this preference.
Trivially fixing it here by disabling the pref before the first call.

Test plan:
[1] Do not apply this patch yet. Enable IndependentBranches.
[2] Run Members.t and observe that it fails.
[3] Apply this patch. And run Members.t again. It should pass now.

Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com>
Comment 3 Jonathan Druart 2017-08-25 15:16:28 UTC 
Created attachment 66484 [details] [review]
Bug 19126: Fix Members.t with IndependentBranches set

If you enabled that pref, Members.t fails with:
t/db_dependent/Members.t .. 63/63 # Looks like you failed 15 tests of 63.

The first one is:
t/db_dependent/Members.t .. 32/63
   Failed test 'Staff patron not deleted from list'
   at t/db_dependent/Members.t line 304.

Bottle neck is GetBorrowersToExpunge. The results of that sub depend on the
state of this preference.
Trivially fixing it here by disabling the pref before the first call.

Test plan:
[1] Do not apply this patch yet. Enable IndependentBranches.
[2] Run Members.t and observe that it fails.
[3] Apply this patch. And run Members.t again. It should pass now.

Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 4 Jonathan Druart 2017-08-25 15:27:04 UTC 
Pushed to master for 17.11, thanks to everybody involved!
Comment 5 Fridolin Somers 2017-09-29 13:26:26 UTC 
Pushed to 17.05.x, will be in 17.05.05.
Comment 6 Katrin Fischer 2017-10-01 22:20:19 UTC 
This patch has been pushed to 16.11.x and will be in 16.11.13.
Comment 7 Mason James 2017-11-23 22:08:37 UTC 
Pushed to 16.05.x, for 16.05.18 release