---- Reported by nengard@gmail.com 2008-03-04 06:09:19 ---- I had a Koha user make a great suggestion today. He suggested RSS feeds for the Virtual Shelves so that he could easily bring them into other applications like Drupal and Moodle. This sounded like a pretty easy enhancement to develop. --- Bug imported by chris@bigballofwax.co.nz 2010-05-21 00:36 UTC --- This bug was previously known as _bug_ 1917 at http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=1917 Actual time not defined. Setting to 0.0 CC member bchurch@ptfs.com does not have an account here
Created attachment 38104 [details] [review] Bug 1917 - Add RSS Feeds for Lists Test Plan: 1) Apply this patch 2) Create one or more public lists 3) View the list in the opac 4) Note the new RSS icon next to the list name 5) Open the link in FireFox or an RSS reader 6) You should see an RSS feed of your list with the title and author of each item as a hyperlink to the record details
Created attachment 38105 [details] [review] Bug 1917 - Add RSS Feeds for Lists Test Plan: 1) Apply this patch 2) Create one or more public lists 3) View the list in the opac 4) Note the new RSS icon next to the list name 5) Open the link in FireFox or an RSS reader 6) You should see an RSS feed of your list with the title and author of each item as a hyperlink to the record details
Created attachment 38106 [details] [review] Bug 1917 - Add RSS Feeds for Lists Test Plan: 1) Apply this patch 2) Create one or more public lists 3) View the list in the opac 4) Note the new RSS icon next to the list name 5) Open the link in FireFox or an RSS reader 6) You should see an RSS feed of your list with the title and author of each item as a hyperlink to the record details Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
I know I can't mark this as signed off cause Kyle wrote it - but since I asked for it in 2008 I was excited and signed off on the file but left it as 'needs signoff' for a second sign off. Nicole
Created attachment 38117 [details] [review] [Signed-off] Bug 1917 - Add RSS Feeds for Lists Test Plan: 1) Apply this patch 2) Create one or more public lists 3) View the list in the opac 4) Note the new RSS icon next to the list name 5) Open the link in FireFox or an RSS reader 6) You should see an RSS feed of your list with the title and author of each item as a hyperlink to the record details Signed-off-by: Nicole Engard <nengard@bywatersolutions.com> Followed test plan. Works as expected. Signed-off-by: Marc Véron <veron@veron.ch>
Comment on attachment 38117 [details] [review] [Signed-off] Bug 1917 - Add RSS Feeds for Lists Review of attachment 38117 [details] [review]: ----------------------------------------------------------------- Hi, I love to see work on the low bug numbers! :) The biggest issue here is that the strings from opac-shelves-rss.tt don't appear to be translatable. I updated my po files, but the strings or file name won't show up there. I also found some smaller issues, please see comments below: ::: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves-rss.tt @@ +2,5 @@ > + > +<rss version="2.0"> > + > +<channel> > + <title>[% shelfname %]</title> Why no |html here, but below? @@ +8,5 @@ > + <description>RSS feed for public list [% shelfname | html %]</description> > + > +[% FOREACH i IN itemsloop %] > + <item> > + <title>[% i.title %] by [% i.author %]</title> The by is always shown, even if there is no author. Also because of the included ISBD punctuation in MARC21 this would only be needed/useful for UNIMARC. ::: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt @@ +153,5 @@ > [% IF ( viewshelf ) %]<!-- Viewing a particular shelf --> > + <h3> > + [% shelfname |html %] > + <a href="[% OPACBaseURL %]/cgi-bin/koha/opac-shelves.pl?rss=1&viewshelf=[% shelfnumber | html %]" class="rss-list-link noprint"> > + <img src="[% interface %]/[% theme %]/images/feed-icon-16x16.png" alt="Subscribe to this search" title="Subscribe to this search" border="0" class="rsssearchicon"/> Should we adjust the title here? Maybe: Subscribe to this list
Created attachment 38199 [details] [review] Bug 1917 [QA Followup] - Use html filter, only show 'by' if author exists, change link title
Created attachment 38200 [details] [review] Bug 1917 [QA Followup] - Use html filter, remove "by", change link title
Created attachment 38201 [details] [review] Bug 1917 [QA Followup] - Use html filter, only show 'by' if author exists, change link title
With Katrin's help I was able to run the translator tool and it appears to be pickup up the template, so that should no longer be an issue!
Created attachment 38218 [details] [review] [PASSED QA] Bug 1917 - Add RSS Feeds for Lists Test Plan: 1) Apply this patch 2) Create one or more public lists 3) View the list in the opac 4) Note the new RSS icon next to the list name 5) Open the link in FireFox or an RSS reader 6) You should see an RSS feed of your list with the title and author of each item as a hyperlink to the record details Signed-off-by: Nicole Engard <nengard@bywatersolutions.com> Followed test plan. Works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 38219 [details] [review] [PASSED QA] Bug 1917 [QA Followup] - Use html filter, only show 'by' if author exists, change link title Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Functionally I am happy with this, but a little confused about the use/non-use of the html filter - can you explain for the different spots?
Kyle, can you explain please? <link>[% OPACBaseURL %]/cgi-bin/koha/opac-shelves.pl?rss=1&viewshelf=[% shelfnumber %]</link> But: <a href="[% OPACBaseURL %]/cgi-bin/koha/opac-shelves.pl?rss=1&viewshelf=[% shelfnumber | html %]" class="rss-list-link <title>[% shelfname %]</title> But: <description>RSS feed for public list [% shelfname | html %]</description>
Created attachment 38263 [details] [review] Bug 1917 [QA Followup] - Remove unnecessary use of html filter
(In reply to Katrin Fischer from comment #14) > Kyle, can you explain please? > > <link>[% OPACBaseURL %]/cgi-bin/koha/opac-shelves.pl?rss=1&viewshelf=[% > shelfnumber %]</link> > But: > <a href="[% OPACBaseURL > %]/cgi-bin/koha/opac-shelves.pl?rss=1&viewshelf=[% shelfnumber | html > %]" class="rss-list-link > > > <title>[% shelfname %]</title> > But: > <description>RSS feed for public list [% shelfname | html %]</description> That was an accidental use of the html filter. It doesn't help or hurt anything, since the variable will always be an integer. However, I've added a followup to remove the use of the filter. I assume this takes care of the last issue and I've set the status to passed qa. If I'm wrong please reset the status.
I want to test something else before passing qa - thx for the follow-up :)
Hm, I found another thing: The RSS feed will only list the first(?) 20 of a longer list. I am not sure why this happens and if there is a way to get a complete list. We have a system preference for the search results - numSearchRSSResults - maybe it should follow that? But I'd kinda expect it to give a full list or at least have an explanation or a link to get to the full list.
Agreed, I think it should be a the full list. (In reply to Katrin Fischer from comment #18) > Hm, I found another thing: The RSS feed will only list the first(?) 20 of a > longer list. I am not sure why this happens and if there is a way to get a > complete list. > > We have a system preference for the search results - numSearchRSSResults - > maybe it should follow that? But I'd kinda expect it to give a full list or > at least have an explanation or a link to get to the full list.
Created attachment 38325 [details] [review] Bug 1917 [QA Followup] - Don't limit the list results for RSS feeds
Created attachment 38332 [details] [review] Bug 1917 - Add RSS Feeds for Lists Test Plan: 1) Apply this patch 2) Create one or more public lists 3) View the list in the opac 4) Note the new RSS icon next to the list name 5) Open the link in FireFox or an RSS reader 6) You should see an RSS feed of your list with the title and author of each item as a hyperlink to the record details Signed-off-by: Nicole Engard <nengard@bywatersolutions.com> Followed test plan. Works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 38333 [details] [review] Bug 1917 [QA Followup] - Use html filter, only show 'by' if author exists, change link title Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 38334 [details] [review] Bug 1917 [QA Followup] - Remove unnecessary use of html filter Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 38335 [details] [review] Bug 1917 [QA Followup] - Don't limit the list results for RSS feeds Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Followups all look sound to me.. passing qa.
Patches pushed to master. Thanks Kyle!