The SelfCheckoutByLogin lists 'Barcode' as an option, but this should be Cardnumber. Especially since more and more libraries are using chip cards instead of barcodes.
Created attachment 67406 [details] [review] Bug 19186: Change pref choice for SelfCheckoutByLogin - barcode vs cardnumber The SelfCheckoutByLogin lists 'Barcode' as an option, but this should be Cardnumber. Especially since more and more libraries are using chip cards instead of barcodes.
Note: this pref is not in sysprefs.sql (?)
Created attachment 67487 [details] [review] Bug 19186: Change pref choice for SelfCheckoutByLogin - barcode vs cardnumber The SelfCheckoutByLogin lists 'Barcode' as an option, but this should be Cardnumber. Especially since more and more libraries are using chip cards instead of barcodes. Signed-off-by: David Bourgault <david.bourgault@inlibro.com>
git grep SelfCheckoutByLogin found no SQL files or anything that looked like an insertion...
Created attachment 68073 [details] [review] Bug 19186: Change pref choice for SelfCheckoutByLogin - barcode vs cardnumber The SelfCheckoutByLogin lists 'Barcode' as an option, but this should be Cardnumber. Especially since more and more libraries are using chip cards instead of barcodes. Signed-off-by: David Bourgault <david.bourgault@inlibro.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Created attachment 68074 [details] [review] Bug 19186: (QA follow-up) Insert syspref SelfCheckoutByLogin if missing Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Pushed to master for 17.11, thanks to everybody involved!