To reproduce: 1) Find a record with an item that has no itemtype (or remove the itemtype of an item) 2) Go to Acquisitions -> Find a vendor or make a new one -> create a new basket 3) Add the record from Step 1 to your basket 4) Close the basket 5) Go back to the vendor and click 'Receive shipments' 6) Put in an invoice number, click Next 7) Click the Receive link for your item 8) Confirm you see an internal server error In the error log: Can't call method "description" on an undefined value at /home/vagrant/kohaclone/acqui/orderreceive.pl line 150.
Created attachment 66573 [details] [review] Bug 19194: Check itemtype is defined when receiving an order To test: 1) Find a record with an item that has no itemtype (or remove the itemtype of an item) 2) Go to Acquisitions -> Find a vendor or make a new one -> create a new basket 3) Add the record from Step 1 to your basket 4) Close the basket 5) Go back to the vendor and click 'Receive shipments' 6) Put in an invoice number, click Next 7) Click the Receive link for your item 8) Confirm you see an internal server error 9) Apply the patch and refresh the page 10) The error should be gone and behaviour should continue as expected Sponsored-by: Catalyst IT
I am going to check this patch, just one quick question.. when you say itemtype you refer to items.itype right? itemtype If I am not wrong refers to tag 942$c of the bibliografic according the text I guess you're refereing to itype, please may you confirm?
Created attachment 66674 [details] [review] Bug 19194: Check itemtype is defined when receiving an order To test: 1) Find a record with an item that has no itemtype (or remove the itemtype of an item) 2) Go to Acquisitions -> Find a vendor or make a new one -> create a new basket 3) Add the record from Step 1 to your basket 4) Close the basket 5) Go back to the vendor and click 'Receive shipments' 6) Put in an invoice number, click Next 7) Click the Receive link for your item 8) Confirm you see an internal server error 9) Apply the patch and refresh the page 10) The error should be gone and behaviour should continue as expected Sponsored-by: Catalyst IT Signed-off-by: Lee Jamison <ldjamison@marywood.edu>
(In reply to Hugo Agud from comment #2) > I am going to check this patch, just one quick question.. when you say > itemtype you refer to items.itype right? itemtype If I am not wrong refers > to tag 942$c of the bibliografic > > according the text I guess you're refereing to itype, please may you confirm? I did mean itemtype as in tag 942c
Created attachment 66682 [details] [review] Bug 19194: Check itemtype is defined when receiving an order To test: 1) Find a record with an item that has no itemtype (or remove the itemtype of an item) 2) Go to Acquisitions -> Find a vendor or make a new one -> create a new basket 3) Add the record from Step 1 to your basket 4) Close the basket 5) Go back to the vendor and click 'Receive shipments' 6) Put in an invoice number, click Next 7) Click the Receive link for your item 8) Confirm you see an internal server error 9) Apply the patch and refresh the page 10) The error should be gone and behaviour should continue as expected Sponsored-by: Catalyst IT Signed-off-by: Lee Jamison <ldjamison@marywood.edu> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Pushed to master for 17.11, thanks to everybody involved!
Depends on Bug 17843 but can easily adapt for 17.05.x
Pushed to 17.05.x, will be in 17.05.04. Depends on Bug 17843 but can easily adapt for 17.05.x
Depending bug is not in 16.11.x
*** Bug 19063 has been marked as a duplicate of this bug. ***