To recreate: 1 - Set a rule to limit checkouts to a single issue, allowing renewal 2 - Issue an item to a patron 3 - Issue the same item 4 - In staff client you get a confirm to renew and a notice of Too Many checkouts 5 - VIA Sip - you get a renewal response, but in logs the renewal fails as a 'too many'
Created attachment 66584 [details] [review] Bug 19198 - Unit tests
Created attachment 66585 [details] [review] Bug 19198 - Renewal as issue causes too many error This patch moves some code and prevents checking for too many checkouts when performing a renewal via checkout To test: 1 - Set a rule to limit checkouts to a single issue, allowing renewal 2 - Issue an item to a patron 3 - Issue the same item 4 - In staff client you get a confirm to renew and a notice of Too Many checkouts, don't confirm 5 - VIA Sip - you get a renewal response, but in logs the renewal fails as a 'too 6 - Apply patch 7 - Via staff client you shoudl get renewal confirm with no too many error 8 - SIP checkout should renew
Created attachment 66670 [details] [review] Bug 19198 - Unit tests Signed-off-by: Lee Jamison <ldjamison@marywood.edu>
Created attachment 66671 [details] [review] Bug 19198 - Renewal as issue causes too many error This patch moves some code and prevents checking for too many checkouts when performing a renewal via checkout To test: 1 - Set a rule to limit checkouts to a single issue, allowing renewal 2 - Issue an item to a patron 3 - Issue the same item 4 - In staff client you get a confirm to renew and a notice of Too Many checkouts, don't confirm 5 - VIA Sip - you get a renewal response, but in logs the renewal fails as a 'too 6 - Apply patch 7 - Via staff client you shoudl get renewal confirm with no too many error 8 - SIP checkout should renew Signed-off-by: Lee Jamison <ldjamison@marywood.edu>
QA: Looking here now
cd t/db_dependent/; git grep -l CanBookBeIssued | xargs prove not ok 8 - Not a specific case, $delta should not be incremented # Failed test 'Not a specific case, $delta should not be incremented' # at t/db_dependent/Circulation/SwitchOnSiteCheckouts.t line 146. # got: undef # expected: 'TOO_MANY_CHECKOUTS'
Created attachment 67111 [details] [review] Bug 19198 - Unit tests Signed-off-by: Lee Jamison <ldjamison@marywood.edu>
Created attachment 67112 [details] [review] Bug 19198 - Renewal as issue causes too many error This patch moves some code and prevents checking for too many checkouts when performing a renewal via checkout To test: 1 - Set a rule to limit checkouts to a single issue, allowing renewal 2 - Issue an item to a patron 3 - Issue the same item 4 - In staff client you get a confirm to renew and a notice of Too Many checkouts, don't confirm 5 - VIA Sip - you get a renewal response, but in logs the renewal fails as a 'too 6 - Apply patch 7 - Via staff client you shoudl get renewal confirm with no too many error 8 - SIP checkout should renew Signed-off-by: Lee Jamison <ldjamison@marywood.edu>
Created attachment 67113 [details] [review] Bug 19198 (QA Followup) Fix typo in conditions '&' should be '&&'
Sorry Nick, can you rebase?
Created attachment 67567 [details] [review] Bug 19198 - Unit tests Signed-off-by: Lee Jamison <ldjamison@marywood.edu>
Created attachment 67568 [details] [review] Bug 19198 - Renewal as issue causes too many error This patch moves some code and prevents checking for too many checkouts when performing a renewal via checkout To test: 1 - Set a rule to limit checkouts to a single issue, allowing renewal 2 - Issue an item to a patron 3 - Issue the same item 4 - In staff client you get a confirm to renew and a notice of Too Many checkouts, don't confirm 5 - VIA Sip - you get a renewal response, but in logs the renewal fails as a 'too 6 - Apply patch 7 - Via staff client you shoudl get renewal confirm with no too many error 8 - SIP checkout should renew Signed-off-by: Lee Jamison <ldjamison@marywood.edu>
Created attachment 67569 [details] [review] Bug 19198 (QA Followup) Fix typo in conditions '&' should be '&&'
Created attachment 67571 [details] [review] Bug 19198: Unit tests Signed-off-by: Lee Jamison <ldjamison@marywood.edu> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 67572 [details] [review] Bug 19198: Renewal as issue causes too many error This patch moves some code and prevents checking for too many checkouts when performing a renewal via checkout To test: 1 - Set a rule to limit checkouts to a single issue, allowing renewal 2 - Issue an item to a patron 3 - Issue the same item 4 - In staff client you get a confirm to renew and a notice of Too Many checkouts, don't confirm 5 - VIA Sip - you get a renewal response, but in logs the renewal fails as a 'too 6 - Apply patch 7 - Via staff client you shoudl get renewal confirm with no too many error 8 - SIP checkout should renew Signed-off-by: Lee Jamison <ldjamison@marywood.edu> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 67573 [details] [review] Bug 19198: (QA followup) Fix typo in conditions '&' should be '&&' Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
I think Tomas just didn't change status, revert if I am wrong :-)
Created attachment 67719 [details] [review] Bug 19198: do not autovivify
Created attachment 67720 [details] [review] Bug 19198: Prevent the test to fail randomly If categorycode is 'X', the test will fail
Pushed to master for 17.11, thanks to everybody involved!