To reproduce: 1) Ensure the useDischarge syspref is enabled 2) Log in to OPAC 3) Go to 'ask for a discharge' 4) Notice warns: Use of uninitialized value $op in string eq at /home/vagrant/kohaclone/opac/opac-discharge.pl line 50. Use of uninitialized value $op in string eq at /home/vagrant/kohaclone/opac/opac-discharge.pl line 62.
Created attachment 66660 [details] [review] Bug 19212: Preventing warns when asking for discharge To test: 1) Ensure the useDischarge syspref is enabled 2) Log in to OPAC 3) Go to 'ask for a discharge' 4) Notice warns 5) Apply patch and refresh page 6) Notice warns are gone Sponsored-by: Catalyst IT
Hi Aleisha, I was unable to replicate the warns. When asking for a discharge I am just told it will be avealable in a few days without any errors.
(In reply to Claire Gravely from comment #2) > Hi Aleisha, > > I was unable to replicate the warns. When asking for a discharge I am just > told it will be avealable in a few days without any errors. I can confirm the warnings (in plack-error.log)
Created attachment 67081 [details] [review] Bug 19212: Preventing warns when asking for discharge To test: 1) Ensure the useDischarge syspref is enabled 2) Log in to OPAC 3) Go to 'ask for a discharge' 4) Notice warns 5) Apply patch and refresh page 6) Notice warns are gone Sponsored-by: Catalyst IT Warnings reproduced in plack-error.log, with patch they are gone. Signed-off-by: Marc Véron <veron@veron.ch>
Created attachment 68727 [details] [review] Bug 19212: Preventing warns when asking for discharge To test: 1) Ensure the useDischarge syspref is enabled 2) Log in to OPAC 3) Go to 'ask for a discharge' 4) Notice warns 5) Apply patch and refresh page 6) Notice warns are gone Sponsored-by: Catalyst IT Warnings reproduced in plack-error.log, with patch they are gone. Signed-off-by: Marc Véron <veron@veron.ch>
Pushed to master for 17.11, thanks to everybody involved!