Created attachment 66759 [details] snapshop of the bug 1. OPAC Self Registration 2. Type password 3. Password characters visible
Created attachment 66768 [details] [review] Bug 19235: Password entry visible in OPAC Self-registration The HTML code was "text" instead of "password". TEST PLAN ---------- 1) 'Allow' PatronSelfRegistration system preference 2) Define the PatronSelfRegistrationDefaultCategory system preference (e.g. PT) 3) Open OPAC 4) Click 'Register here' on the right. (/cgi-bin/koha/opac-memberentry.pl) 5) Scroll to bottom 6) enter some passwords -- visible 7) apply this patch 8) refresh page 9) repeat 5-6 as needed -- passwords should not be visible while entering 10) run koha qa test tools
Created attachment 66782 [details] [review] Bug 19235: Password entry visible in OPAC Self-registration The HTML code was "text" instead of "password". TEST PLAN ---------- 1) 'Allow' PatronSelfRegistration system preference 2) Define the PatronSelfRegistrationDefaultCategory system preference (e.g. PT) 3) Open OPAC 4) Click 'Register here' on the right. (/cgi-bin/koha/opac-memberentry.pl) 5) Scroll to bottom 6) enter some passwords -- visible 7) apply this patch 8) refresh page 9) repeat 5-6 as needed -- passwords should not be visible while entering 10) run koha qa test tools Signed-off-by: Lee Jamison <ldjamison@marywood.edu>
The steps has been followed and tested OK Noe the password character are not visible.
Created attachment 67008 [details] [review] Bug 19235: Password entry visible in OPAC Self-registration The HTML code was "text" instead of "password". TEST PLAN ---------- 1) 'Allow' PatronSelfRegistration system preference 2) Define the PatronSelfRegistrationDefaultCategory system preference (e.g. PT) 3) Open OPAC 4) Click 'Register here' on the right. (/cgi-bin/koha/opac-memberentry.pl) 5) Scroll to bottom 6) enter some passwords -- visible 7) apply this patch 8) refresh page 9) repeat 5-6 as needed -- passwords should not be visible while entering 10) run koha qa test tools Signed-off-by: Lee Jamison <ldjamison@marywood.edu> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Pushed to master for 17.11, thanks to everybody involved!
Pushed to 17.05.x, will be in 17.05.04.
This patch has been pushed to 16.11.x and will be in 16.11.12.