Bug 19247 - Feature release change tool
Summary: Feature release change tool
Status: RESOLVED DUPLICATE of bug 18645
Alias: None
Product: Koha
Classification: Unclassified
Component: Installation and upgrade (web-based installer) (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Alex Buckley
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-09-04 02:18 UTC by Alex Buckley
Modified: 2019-06-19 08:56 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 18645 -Koha feature release change tool (102.26 KB, patch)
2017-09-04 03:21 UTC, Alex Buckley
Details | Diff | Splinter Review
Bug 19247 - Followup: QA test tool fixes (5.32 KB, patch)
2017-09-27 19:37 UTC, Alex Buckley
Details | Diff | Splinter Review
Bug 19247 - Followup: QA test tool fixes (5.23 KB, patch)
2017-09-27 21:12 UTC, Alex Buckley
Details | Diff | Splinter Review
Bug 18645 -Koha feature release change tool (102.26 KB, patch)
2017-10-14 01:28 UTC, Alex Buckley
Details | Diff | Splinter Review
Bug 19247 - Followup: QA test tool fixes (24.59 KB, patch)
2017-10-14 01:28 UTC, Alex Buckley
Details | Diff | Splinter Review
Bug 19247 - Working on displaying the values of the system preferences in correct format (29.67 KB, patch)
2017-10-14 01:29 UTC, Alex Buckley
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Buckley 2017-09-04 02:18:36 UTC

    
Comment 1 Alex Buckley 2017-09-04 03:21:09 UTC
Created attachment 66792 [details] [review]
Bug 18645 -Koha feature release change tool

This tool is displayed at the end of the update process to display all
the new system preferences added during the update so that the
administrator can view and modify their default values if neccessary

Link to the release notes for the most recent installed release are also
provided by this tool.

Test plan:
1. Go to Administrator->global system preferences->Local use

2. Set the version number to 16.1200033 (Note: only 1 decimal place) and
save

3. Go through the update process and notice that after submitting the 'Update database structure" page you are prompted to login and the main page appears if you logged in with the correct credentials

4. Apply patch

5. Repeat steps 1, and 2

6. Notice the button text on the 'Update database structure' page has
changed and now it says 'Continue to feature release tool'

7. The feature release tool will be displayed. Click on the 'New Syspref
information' tab and notice that the system preferences (names,
explanations and (editable) default values) installed in the
update process are displayed

8. Change the value of TranslateNotices syspref and click the 'Save all
preferences' button

9. Refresh the page manually and click on the 'New syspref information'
tab and notice the value of the TranslateNotices syspref has been
altered

10. Click on the 'Release notes' tab and open the release note link
which is 17.05 release notes

11. Leave the feature release change tool by clicking the 'Next and
submit' button

12. You are prompted to login, after entering the correct credentials
the intranet main page is displayed

Sponsored-by: Catalyst IT
Comment 2 Alex Buckley 2017-09-27 19:37:30 UTC
Created attachment 67415 [details] [review]
Bug 19247 - Followup: QA test tool fixes

Test plan:
1. Run QA test tools and notice that all files pass
Comment 3 Alex Buckley 2017-09-27 21:12:56 UTC
Created attachment 67419 [details] [review]
Bug 19247 - Followup: QA test tool fixes

Test plan:
1. Run QA test tools and notice that all files pass
Comment 4 Alex Buckley 2017-10-14 01:28:32 UTC
Created attachment 68113 [details] [review]
Bug 18645 -Koha feature release change tool

This tool is displayed at the end of the update process to display all
the new system preferences added during the update so that the
administrator can view and modify their default values if neccessary

Link to the release notes for the most recent installed release are also
provided by this tool.

Test plan:
1. Go to Administrator->global system preferences->Local use

2. Set the version number to 16.1200033 (Note: only 1 decimal place) and
save

3. Go through the update process and notice that after submitting the 'Update database structure" page you are prompted to login and the main page appears if you logged in with the correct credentials

4. Apply patch

5. Repeat steps 1, and 2

6. Notice the button text on the 'Update database structure' page has
changed and now it says 'Continue to feature release tool'

7. The feature release tool will be displayed. Click on the 'New Syspref
information' tab and notice that the system preferences (names,
explanations and (editable) default values) installed in the
update process are displayed

8. Change the value of TranslateNotices syspref and click the 'Save all
preferences' button

9. Refresh the page manually and click on the 'New syspref information'
tab and notice the value of the TranslateNotices syspref has been
altered

10. Click on the 'Release notes' tab and open the release note link
which is 17.05 release notes

11. Leave the feature release change tool by clicking the 'Next and
submit' button

12. You are prompted to login, after entering the correct credentials
the intranet main page is displayed

Sponsored-by: Catalyst IT
Comment 5 Alex Buckley 2017-10-14 01:28:49 UTC
Created attachment 68114 [details] [review]
Bug 19247 - Followup: QA test tool fixes

Test plan:
1. Run QA test tools and notice that all files pass
Comment 6 Alex Buckley 2017-10-14 01:29:04 UTC
Created attachment 68115 [details] [review]
Bug 19247 - Working on displaying the values of the system preferences in correct format

Sponsored-By: Catalyst IT
Comment 7 Katrin Fischer 2017-12-05 06:33:47 UTC
Hi Alex, check the system preference editor - I just noticed I still had your patch from before applied and it seemed to break the pull downs in the editor.
Comment 8 Katrin Fischer 2017-12-05 06:39:04 UTC
Just took a look at the last patch, what is display_choices supposed to do?

display_choices="Don't show|Show" WHERE variable="IntranetCatalogSearchPulldown";

On first glance, this looks like a translatability issue - why have them in the database and in the translatable yaml file?
Comment 9 Alex Buckley 2017-12-11 21:08:50 UTC
Hi Katrin

Sorry for not replying sooner. 

The purpose of display_choices is a way of displaying option values in the feature Release Change Tool.

I cannot use the YAML files because they are organised by their functionality, e.g. there is a admin.pref for all administration related system preferences. 

I want to retrieve and display the system preferences by the version they were added in and so it would require a very complex regular expression to go through each of the YAML files to find the system preference with a matching name.

Whereas by having the display_choices values in the database in records containing the version number I can both retrieve the system preference information and display information in one go. 

So that was my rationale for the display_choices.

I hope that makes sense :)
Comment 10 Chris Cormack 2017-12-11 21:13:49 UTC
Hmm the problem with the db, is it is not translatable, which will make this tool not useful for non English users. (which is a lot of the world)

Also they will get out of sync with the yaml files pretty fast.
Maybe look into the code that does the syspref search now, and see if you can reuse that? It is searching over the yaml files
Comment 11 Martin Renvoize 2018-10-30 10:48:51 UTC
This looks like a great feature.. are you intending to breathe any further life into it Alex... be another great one to showcase in 18.11.
Comment 12 Alex Buckley 2018-10-30 22:24:53 UTC
Hi Martin

Thanks very much. 

Yes, I would like to breathe more life into this one. I have been busy testing patches over the last while, I can start working on revisiting this one tonight to try to move it along.

Will be in touch when it is ready to test :)

Cheers,
Alex
Comment 13 David Cook 2018-10-30 23:42:33 UTC
This does sound cool!
Comment 14 Martin Renvoize 2019-05-11 08:49:29 UTC
So we missed 18.11 and we're about to miss 19.05.  Mind if I adopt this one at the beginning of the next cycle so we can get it in there for 19.11?
Comment 15 Martin Renvoize 2019-06-10 07:28:12 UTC
So, a little bird told me you're back from an amazing break and feel refreshed and raring to go Alex... is this bug still on your horizon?
Comment 16 Alex Buckley 2019-06-11 20:09:51 UTC
Hi Martin, 

Yes I have returned from an amazing break!

The patches on this bug report are a duplicate of bug 18645 so perhaps we should mark this bug report as a duplicate and concentrate on 18645. How does that sound?

Aleisha has been doing some work rebasing 18645 and I think if we all work together on 18645 we should be able to move that along. 

Cheers,
Alex
Comment 17 Katrin Fischer 2019-06-18 22:20:25 UTC
Martin, do you want to mark as duplicate as Alex suggests? Didn't want to change the RM_Priority :)
Comment 18 Martin Renvoize 2019-06-19 08:56:38 UTC

*** This bug has been marked as a duplicate of bug 18645 ***