CGI::param called in list context from package CGI::Compile::ROOT::home_vagrant_kohaclone_acqui_basket_2epl line 229, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at /usr/share/perl5/CGI.pm line 436.
Created attachment 66858 [details] [review] Bug 19257: Prevent warn when reopening a basket To test: 1) Go to Acquisitions, find a vendor and a basket (create if you don't have either) 2) Close the basket 3) View the basket and reopen it 4) Notice the warn 5) Apply the patch and repeat steps 1-3 6) Notice the warn no longer shows and the basket is reopened as expected Sponsored-by: Catalyst IT
Created attachment 66863 [details] [review] Bug 19257: Prevent warn when reopening a basket To test: 1) Go to Acquisitions, find a vendor and a basket (create if you don't have either) 2) Close the basket 3) View the basket and reopen it 4) Notice the warn 5) Apply the patch and repeat steps 1-3 6) Notice the warn no longer shows and the basket is reopened as expected Sponsored-by: Catalyst IT Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Created attachment 66957 [details] [review] Bug 19257: Prevent warn when reopening a basket To test: 1) Go to Acquisitions, find a vendor and a basket (create if you don't have either) 2) Close the basket 3) View the basket and reopen it 4) Notice the warn 5) Apply the patch and repeat steps 1-3 6) Notice the warn no longer shows and the basket is reopened as expected Sponsored-by: Catalyst IT Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Pushed to master for 17.11, thanks to everybody involved!
Pushed to 17.05.x, will be in 17.05.05.
This patch has been pushed to 16.11.x and will be in 16.11.13.
Pushed to 16.05.x, for 16.05.18 release