Bug 19268 - Fix wrong TestBuilder parameter in few unit tests
Summary: Fix wrong TestBuilder parameter in few unit tests
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Test Suite (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Marcel de Rooy
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks: 15339
  Show dependency tree / graph
 
Reported: 2017-09-07 09:51 UTC by Marcel de Rooy
Modified: 2018-06-04 20:10 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Bug 19268: Fix TestBuilder parameter in C/Branch.t and K/P/Messaging.t (2.35 KB, patch)
2017-09-07 09:58 UTC, Marcel de Rooy 		Details | Diff | Splinter Review
Bug 19268: Fix TestBuilder parameter in C/Branch.t and K/P/Messaging.t (2.40 KB, patch)
2017-09-07 16:52 UTC, Jonathan Druart 		Details | Diff | Splinter Review
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Marcel de Rooy 2017-09-07 09:51:49 UTC 
Bug 15339 made these errors visible.
The values parameter should be value.
Comment 1 Marcel de Rooy 2017-09-07 09:58:26 UTC 
Created attachment 66918 [details] [review]
Bug 19268: Fix TestBuilder parameter in C/Branch.t and K/P/Messaging.t

The values parameter should be called value.
See bug 15339.

Test plan:
Run the adjusted tests.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 2 Marcel de Rooy 2017-09-07 10:22:33 UTC 
Jonathan: This could go along with 15339, but does not depend on it.
Funny that these tests passed with other values than expected..
Comment 3 Jonathan Druart 2017-09-07 16:52:49 UTC 
Created attachment 66949 [details] [review]
Bug 19268: Fix TestBuilder parameter in C/Branch.t and K/P/Messaging.t

The values parameter should be called value.
See bug 15339.

Test plan:
Run the adjusted tests.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 4 Jonathan Druart 2017-09-07 18:09:02 UTC 
Pushed to master for 17.11, thanks to everybody involved!
Comment 5 Fridolin Somers 2017-10-10 09:52:07 UTC 
Depends on Bug 15339 that is not in 17.05.x