We count on getting an issuing impossible, but if this pref enabled we get a needs confirmation
Created attachment 67114 [details] [review] Bug 19307 - Mock the AllowFineOverride preference to ensure expected result To test: 1 - Set 'AllowFineOverride' to allow 2 - prove t/db_dependent/Circulation/NoIssuesChargeGuarantees.t 3 - 1 test fails 4 - Apply patch 5 - prove t/db_dependent/Circulation/NoIssuesChargeGuarantees.t 6 - All tests pass 7 - Set 'AllowFineOverride' to 'Don't allow' 8 - Tests should still pass
Created attachment 67163 [details] [review] Bug 19307 - Mock the AllowFineOverride preference to ensure expected result To test: 1 - Set 'AllowFineOverride' to allow 2 - prove t/db_dependent/Circulation/NoIssuesChargeGuarantees.t 3 - 1 test fails 4 - Apply patch 5 - prove t/db_dependent/Circulation/NoIssuesChargeGuarantees.t 6 - All tests pass 7 - Set 'AllowFineOverride' to 'Don't allow' 8 - Tests should still pass Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
Oops, sorry. I signed off this one by error while trying to sign off another bug (new to git, linux and koha, does it show? haha!)
Created attachment 67320 [details] [review] Bug 19307 - Mock the AllowFineOverride preference to ensure expected result To test: 1 - Set 'AllowFineOverride' to allow 2 - prove t/db_dependent/Circulation/NoIssuesChargeGuarantees.t 3 - 1 test fails 4 - Apply patch 5 - prove t/db_dependent/Circulation/NoIssuesChargeGuarantees.t 6 - All tests pass 7 - Set 'AllowFineOverride' to 'Don't allow' 8 - Tests should still pass Signed-off-by: David Bourgault <david.bourgault@inlibro.com>
Created attachment 67408 [details] [review] Bug 19307: Mock the AllowFineOverride preference to ensure expected result To test: 1 - Set 'AllowFineOverride' to allow 2 - prove t/db_dependent/Circulation/NoIssuesChargeGuarantees.t 3 - 1 test fails 4 - Apply patch 5 - prove t/db_dependent/Circulation/NoIssuesChargeGuarantees.t 6 - All tests pass 7 - Set 'AllowFineOverride' to 'Don't allow' 8 - Tests should still pass Signed-off-by: David Bourgault <david.bourgault@inlibro.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Pushed to master for 17.11, thanks to everybody involved!
Pushed to 17.05.x, will be in 17.05.06.
This patch has been pushed to 16.11.x and will be in 16.11.14.
Pushed to 16.05.x, for 16.05.19 release