Small typo: http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_121a.tt;h=bbd5ca00de66e9c9947e6d4814b361c31a71f974;hb=HEAD https://books.google.com.ua/books?id=I9rPDkF0_ZQC&pg=PA149&lpg=PA149&dq=unimarc+121a+3-dimensional&source=bl&ots=eE7pUi4zpj&sig=-B_r27FUL2l1-H4Ke6bI1lCDgMw&hl=uk&sa=X&ved=0ahUKEwjvv9vzpqTWAhXhPZoKHS1jC-0Q6AEIJjAA#v=onepage&q=unimarc%20121a%203-dimensional&f=false Must be: 19 [% IF ( f1b ) %] 20 <option value="b" selected="selected">3-dimensional</option> 21 [% ELSE %] 22 <option value="b">3-dimensional</option> 23 [% END %]
Created attachment 103453 [details] [review] Bug 19312: Fix typo in template This patch fixes a simple typo Test plan: 1) Go to Administration -> MARC bibliographic framework 2) Select a framework and add plugin unimarc_field_121a.pl to 121 field 3) Open cataloguing screen 4) Go to 121 field and check if for subfield a shows two times the value 2-dimensional 5) Apply the patch 6) Go to 121 field again and check if it shows 2 different values Mentored-by: Andreas Roussos
Created attachment 104540 [details] [review] Bug 19312: Fix typo in template This patch fixes a simple typo Test plan: 1) Go to Administration -> MARC bibliographic framework 2) Select a framework and add plugin unimarc_field_121a.pl to 121 field 3) Open cataloguing screen 4) Go to 121 field and check if for subfield a shows two times the value 2-dimensional 5) Apply the patch 6) Go to 121 field again and check if it shows 2 different values Mentored-by: Andreas Roussos Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Change is correct, fixed tab chars.
Created attachment 104554 [details] [review] Bug 19312: Fix typo in template This patch fixes a simple typo Test plan: 1) Go to Administration -> MARC bibliographic framework 2) Select a framework and add plugin unimarc_field_121a.pl to 121 field 3) Open cataloguing screen 4) Go to 121 field and check if for subfield a shows two times the value 2-dimensional 5) Apply the patch 6) Go to 121 field again and check if it shows 2 different values Mentored-by: Andreas Roussos Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Change is correct, fixed tab chars. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Nice work everyone! Pushed to master for 20.05
Backported to 19.11.x for 19.11.06
backported to 19.05.x for 19.05.11