Looks like we never put the title-string spec in on this page to make the dates sort correctly. We should fix that, so that the dates are right in all formats.
Created attachment 67195 [details] [review] Bug 19338 - Dates sorting incorrectly in opac-account.tt To test: Find an account with lots of fines/payments load up the borrower's account in the OPAC note that the sort on the dates sorts by day, and not by date. apply this patch reload the page, note that the sort on the dates is now correct.
Created attachment 67196 [details] [review] Bug 19338 - followup - missing span Oops, missed a span.
With patch applied dates do not sort at all. I think it is because of line 105 in opac-account.tt: <td><span title="[% account.date %]">[% ACCOUNT_LINE.date | $KohaDates %]</td> account.date should be: ACCOUNT_LINE.date
Created attachment 67582 [details] [review] Bug 19338 - Dates sorting incorrectly in opac-account.tt To test: Find an account with lots of fines/payments load up the borrower's account in the OPAC note that the sort on the dates sorts by day, and not by date. apply this patch reload the page, note that the sort on the dates is now correct.
Created attachment 67801 [details] [review] Bug 19338 - Dates sorting incorrectly in opac-account.tt To test: Find an account with lots of fines/payments load up the borrower's account in the OPAC note that the sort on the dates sorts by day, and not by date. apply this patch reload the page, note that the sort on the dates is now correct. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 70154 [details] [review] Bug 19338 - Dates sorting incorrectly in opac-account.tt To test: Find an account with lots of fines/payments load up the borrower's account in the OPAC note that the sort on the dates sorts by day, and not by date. apply this patch reload the page, note that the sort on the dates is now correct. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com>
Pushed to master for 18.05, thanks to everybody involved!
Awesome work all, pushed to stable for 17.11.02
Pushed to 17.05.x for v17.05.08