Due to a bad rebase, the borrowers and deletedborrowers table structure may different from a new install and upgraded install
Created attachment 67220 [details] [review] Bug 19344: Reorder lang and login_attempts in the [deleted]borrowers tables Due to a bad rebase, the borrowers and deletedborrowers table structure may different from a new install and upgraded install For new installs, the order was: lang, login_attempts For upgraded installs, it was lang, last_seen, login_attempts After this patch, the order must be: - last_seen - lang - login_attempts
Went back to 16.05 did drop/create and reset_all. checked the DB, didn't see the fields in question, though they may have been ordered differently then. changed to master, ran upgrade. different order confirmed. applied patch order corrected. drop/create and reset_all check the DB, fields are in the expected order (with overdrive_auth_token at the end).
Created attachment 67222 [details] [review] Bug 19344: Reorder lang and login_attempts in the [deleted]borrowers tables Due to a bad rebase, the borrowers and deletedborrowers table structure may different from a new install and upgraded install For new installs, the order was: lang, login_attempts For upgraded installs, it was lang, last_seen, login_attempts After this patch, the order must be: - last_seen - lang - login_attempts Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Created attachment 67466 [details] [review] Bug 19344: Reorder lang and login_attempts in the [deleted]borrowers tables Due to a bad rebase, the borrowers and deletedborrowers table structure may different from a new install and upgraded install For new installs, the order was: lang, login_attempts For upgraded installs, it was lang, last_seen, login_attempts After this patch, the order must be: - last_seen - lang - login_attempts Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Pushed to master for 17.11, thanks to everybody involved!
Pushed to 17.05.x, will be in 17.05.06.
Both dependent bugs are not part of 16.11.x, so this should not be needed there. Closing.