If the call to SendPasswordRecoveryEmail(...) in opac-password-recovery.pl fails, a error message should be displayed, but it's not. To reproduce: - Force SendPasswordRecoveryEmail() failure - Easiest way is to the file opac-password-recovery.pl and replace the 'elsif (SendPassword...' at line 131 by 'elsif ( 0 ) {' - Attempt to recover a user's password with valid login+email combo. A message saying "An error has occurred while sending you the password recovery link." should be displayed, but it is not.
Created attachment 67221 [details] [review] Bug 19345 - Add missing error flag to template Adds a missing error flag to the template->param { } call. To test : same procedure as above, after applying patch. Error message will display correctly.
Created attachment 67223 [details] [review] Bug 19345 - Add missing error flag to template Adds a missing error flag to the template->param { } call. Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Created attachment 67667 [details] [review] Bug 19345 - Add missing error flag to template Adds a missing error flag to the template->param { } call. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Updated assignee field. If you pick up a bug, please change the Assignee field, David. Thanks.
First patch in, David, congrats! Pushed to master for 17.11, thanks to everybody involved!
Pushed to 17.05.x, will be in 17.05.06.
This patch has been pushed to 16.11.x and will be in 16.11.14.
Pushed to 16.05.x, for 16.05.19 release