Submitting a batch of biblionumbers to batch record modification results in an error: Template process failed: undef error - The method itemnumbers is not covered by tests! at /home/vagrant/kohaclone/C4/Templates.pm line 121.
Caused by commit c73e269a13f64fe016dc90941280c9d2e9cfb02c Bug 18260: Koha::Biblio - Remove GetBiblio
Created attachment 67279 [details] [review] Bug 19357: (bug 18260 follow-up) Remove non-relevant attributes When created, batch_record_modification.tt has been based on batch_delete_records.tt These attributes are not used in the template and not set in the pl script. Since bug 18260, biblio is a Koha::Biblio and calling a non-existent method will raise an error. This patch get rid of the following error: batch_record_modification.pl: Template process failed: undef error - The method itemnumbers is not covered by tests! Test plan: Modify bibliographic records with the "Batch record modification" tool.
Note that this patch can be backported, but I prefer to keep the dependency with bug 18260.
Created attachment 67280 [details] [review] [SIGNED-OFF] Bug 19357: (bug 18260 follow-up) Remove non-relevant attributes When created, batch_record_modification.tt has been based on batch_delete_records.tt These attributes are not used in the template and not set in the pl script. Since bug 18260, biblio is a Koha::Biblio and calling a non-existent method will raise an error. This patch get rid of the following error: batch_record_modification.pl: Template process failed: undef error - The method itemnumbers is not covered by tests! Test plan: Modify bibliographic records with the "Batch record modification" tool. Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 67438 [details] [review] Bug 19357: (bug 18260 follow-up) Remove non-relevant attributes When created, batch_record_modification.tt has been based on batch_delete_records.tt These attributes are not used in the template and not set in the pl script. Since bug 18260, biblio is a Koha::Biblio and calling a non-existent method will raise an error. This patch get rid of the following error: batch_record_modification.pl: Template process failed: undef error - The method itemnumbers is not covered by tests! Test plan: Modify bibliographic records with the "Batch record modification" tool. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Pushed to master for 17.11, thanks to everybody involved!
Depends on Bug 18260 that is not in 17.05.x