Bug 19363 - QA test tools fails detail.tt template
Summary: QA test tools fails detail.tt template
Status: CLOSED INVALID
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-09-25 04:35 UTC by Alex Buckley
Modified: 2018-06-04 20:10 UTC (History)
0 users

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Buckley 2017-09-25 04:35:37 UTC
One of the files I have worked on in bug 19360 is detail.tt after finishing the patch I ran the QA test tool and it passed for all files except the detail.tt (see below) I reverted the changes I had made to this file and it still gave the same result and so I believe this template bug has been introduced from a previous patch: 

 FAIL	koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
   OK	  forbidden patterns
   OK	  git manipulation
   OK	  spelling
   OK	  tt_valid
   FAIL	  valid_template
		Attempt to reload Koha/Template/Plugin/Koha.pm aborted.
Compilation failed in require at /usr/lib/x86_64-linux-gnu/perl5/5.20/Template/Plugins.pm line 206.
Comment 1 Owen Leonard 2017-10-04 14:25:16 UTC
I tried to reproduce this bug on my kohadevbox by making a trivial change to detail.tt and running the QA test tool, but I didn't get any failures.
Comment 2 Alex Buckley 2017-10-04 20:14:47 UTC
(In reply to Owen Leonard in comment 1)

Hi Owen

Yes sorry I was having issues with QA test tools, I have now fixed those issues and this bug no longer exists.