At present on the circ/circulation.tt file there is a table column header with the text: 'Delete?' However after the user has selected the 'Yes' option in the dropdown boxes in this column then there is no button on the page with the text 'Delete' in it instead they have to click a button with the text 'Cancel marked holds' Using both 'Delete' and 'Cancel' on the same page causes confusion and so this minor patch will change the table column text to 'Cancel?'
Created attachment 67391 [details] [review] Bug: 19371: Changed table column text to 'Cancel?' on the patron circulation page Test plan: 1. Place a hold on an item 2. Search for the patron who the hold is associated with 3. View the Hold(s) tab of the Checkouts page and notice there is a column with the text 'Delete?' and a button below the table with the text 'Cancel marked holds' 4. Apply patch 5. Notice that the column text described in step 3 now has the text 'Cancel?' and the button text is the same as it was in step 3 Sponsored-By: Catalyst IT
Created attachment 67425 [details] [review] Bug: 19371: Changed table column text to 'Cancel?' on the patron circulation page Test plan: 1. Place a hold on an item 2. Search for the patron who the hold is associated with 3. View the Hold(s) tab of the Checkouts page and notice there is a column with the text 'Delete?' and a button below the table with the text 'Cancel marked holds' 4. Apply patch 5. Notice that the column text described in step 3 now has the text 'Cancel?' and the button text is the same as it was in step 3 Sponsored-By: Catalyst IT Signed-off-by: Marc Véron <veron@veron.ch>
Created attachment 67755 [details] [review] Bug: 19371: Changed table column text to 'Cancel?' on the patron circulation page Test plan: 1. Place a hold on an item 2. Search for the patron who the hold is associated with 3. View the Hold(s) tab of the Checkouts page and notice there is a column with the text 'Delete?' and a button below the table with the text 'Cancel marked holds' 4. Apply patch 5. Notice that the column text described in step 3 now has the text 'Cancel?' and the button text is the same as it was in step 3 Sponsored-By: Catalyst IT Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Pushed to master for 17.11, thanks to everybody involved!