Created attachment 67395 [details] CircSidebar overlapping transferred items table When CircSidebar is activated, "Transferred items" table at Circulation -> Transfers goes under the sidebar. See attachment. To reproduce: 1. Activate CircSidebar system preference 2. Go to cgi-bin/koha/circ/branchtransfers.pl 3. Enter a barcode and click submit 4. Observe transferred items table under the circulation side bar
Created attachment 67396 [details] [review] Bug 19374: CircSidebar overlapping transferred items table When CircSidebar is activated, "Transferred items" table at Circulation -> Transfers goes under the sidebar. This patch fixes the issue. To test: 1. Enable CircSidebar system preference 2. Go to cgi-bin/koha/circ/branchtransfers.pl 3. Enter a barcode and click submit 4. Observe transferred items table under the circulation side bar 5. Apply patch 6. Enter a barcode and click submit 7. Observe transferred items is now correctly displayed 8. Also test with CircSidebar system preference deactivated
Created attachment 67397 [details] [review] Bug 19374: CircSidebar overlapping transferred items table When CircSidebar is activated, "Transferred items" table at Circulation -> Transfers goes under the sidebar. This patch fixes the issue. To test: 1. Enable CircSidebar system preference 2. Go to cgi-bin/koha/circ/branchtransfers.pl 3. Enter a barcode and click submit 4. Observe transferred items table under the circulation side bar 5. Apply patch 6. Enter a barcode and click submit 7. Observe transferred items is now correctly displayed 8. Also test with CircSidebar system preference deactivated Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 67399 [details] [review] Bug 19374: (follow-up) Remove stray closing div tag To test: 1. Apply first patch and validate the document e.g. here https://validator.w3.org/#validate_by_input 2. Observe "Stray end tag div." error 3. Apply this patch and validate again 4. Observe no errors 5. Go through test plan from first patch to make sure things still look nice
Created attachment 67401 [details] [review] Bug 19374: CircSidebar overlapping transferred items table When CircSidebar is activated, "Transferred items" table at Circulation -> Transfers goes under the sidebar. This patch fixes the issue. To test: 1. Enable CircSidebar system preference 2. Go to cgi-bin/koha/circ/branchtransfers.pl 3. Enter a barcode and click submit 4. Observe transferred items table under the circulation side bar 5. Apply patch 6. Enter a barcode and click submit 7. Observe transferred items is now correctly displayed 8. Also test with CircSidebar system preference deactivated Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Bug 19374: (follow-up) Remove stray closing div tag To test: 1. Apply first patch and validate the document e.g. here https://validator.w3.org/#validate_by_input 2. Observe "Stray end tag div." error 3. Apply this patch and validate again 4. Observe no errors 5. Go through test plan from first patch to make sure things still look nice Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Patches squashed for readability.
Upping severity, it impacts 17.05.x
Created attachment 67681 [details] [review] Bug 19374: CircSidebar overlapping transferred items table When CircSidebar is activated, "Transferred items" table at Circulation -> Transfers goes under the sidebar. This patch fixes the issue. To test: 1. Enable CircSidebar system preference 2. Go to cgi-bin/koha/circ/branchtransfers.pl 3. Enter a barcode and click submit 4. Observe transferred items table under the circulation side bar 5. Apply patch 6. Enter a barcode and click submit 7. Observe transferred items is now correctly displayed 8. Also test with CircSidebar system preference deactivated Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Bug 19374: (follow-up) Remove stray closing div tag To test: 1. Apply first patch and validate the document e.g. here https://validator.w3.org/#validate_by_input 2. Observe "Stray end tag div." error 3. Apply this patch and validate again 4. Observe no errors 5. Go through test plan from first patch to make sure things still look nice Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Pushed to master for 17.11, thanks to everybody involved!
Pushed to 17.05.x, will be in 17.05.06.
Depend on bug 16530 which is not part of 16.11.x, skipping.