In course reserves, if an item which was added to a course is checked out, it is not possible to show details for that course on OPAC. The error says: "Template process failed: undef error - The method onsite_checkout is not covered by tests! at /home/koha/src/C4/Templates.pm line 121."
Created attachment 67475 [details] [review] Bug 19388: FIX display item status if item is checked out In course reserves, if an item which was added to a course is checked out, it is not possible to show details for that course on OPAC. The error says: "Template process failed: undef error - The method onsite_checkout is not covered by tests! at /home/koha/src/C4/Templates.pm line 121." onsite_checkout is an attribute of Koha::Checkout, not Koha::Item Test plan: Create a course with 2 items that are checked out (standard and on-site) At the OPAC, add them to your cart and confirm the status of these 2 items is correct Confirm that on the detail page of the bib record as well as the detail of the course.
Looks like it has been caused by bug 18276.
I tested and it worked. I was able to see the course details.
Created attachment 67485 [details] [review] Bug 18856 - Cancel Waiting Hold in OPAC does not give useful message If a hold is 'waiting' for the patron to collect then the patron should be prevented from cancelling the hold via their account in the opac. If a patron tries to cancel the hold, Koha will give an 'are you sure' alert and when you click Yes the page just refreshes and the hold remains. Staff can cancel the hold from the staff interface but they can then action the waiting hold. I think therefore that it is correct behaviour that a patron cannot cancel a hold when it reaches waiting state via the opac but it would be useful to either have a warning to prevent the cancellation or a useful message when they attempt to do so. The template was using a method that tells Koha if *staff* can cancel a hold, instead of patron. Test Plan: 1) Set up a waiting hold 2) Try to cancel it from the opac 3) Note you cannot 4) Apply this patch 5) Reload the page 6) Note the cancel button has disappeared for found holds Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
Lowering severity, it does not impact stable releases.
Comment on attachment 67485 [details] [review] Bug 18856 - Cancel Waiting Hold in OPAC does not give useful message This patch does not belong here
Created attachment 67676 [details] [review] Bug 19388: FIX display item status if item is checked out In course reserves, if an item which was added to a course is checked out, it is not possible to show details for that course on OPAC. The error says: "Template process failed: undef error - The method onsite_checkout is not covered by tests! at /home/koha/src/C4/Templates.pm line 121." onsite_checkout is an attribute of Koha::Checkout, not Koha::Item Test plan: Create a course with 2 items that are checked out (standard and on-site) At the OPAC, add them to your cart and confirm the status of these 2 items is correct Confirm that on the detail page of the bib record as well as the detail of the course. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Pushed to master for 17.11, thanks to everybody involved!
Depends on Bug 18276 that is not in 17.05.x