Bug 19438 - Sorting by due date in overdues listing does not work as expected
Summary: Sorting by due date in overdues listing does not work as expected
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor
Assignee: Josef Moravec
QA Contact: Marcel de Rooy
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-10-09 08:24 UTC by Josef Moravec
Modified: 2018-06-04 20:18 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Bug 19438: Fix sorting by date due in overdues.pl (3.22 KB, patch)
2017-10-09 08:34 UTC, Josef Moravec 		Details | Diff | Splinter Review
Bug 19438: Fix sorting by date due in overdues.pl (3.27 KB, patch)
2017-10-11 18:50 UTC, Owen Leonard 		Details | Diff | Splinter Review
Bug 19438: Fix sorting by date due in overdues.pl (3.36 KB, patch)
2017-10-13 09:31 UTC, Marcel de Rooy 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Josef Moravec 2017-10-09 08:24:58 UTC 

    


    


      



        
          Comment 1
        

        
          Josef Moravec

        

        
        

        
          2017-10-09 08:34:08 UTC
        

      






Created attachment 67831 [details] [review]
Bug 19438: Fix sorting by date due in overdues.pl

Test plan:
0) Do not apply the patch
1) Have some overdued checkouts in your database
2) Go to circulation -> overdues (overdues.pl)
3) Try to sort the overdues table by due date and notice it is sorted
alphabetically, not by date
4) Apply the patch
5) Try again and confirm, it is sorted by date

    


    


      



        
          Comment 2
        

        
          Owen Leonard

        

        
        

        
          2017-10-11 18:50:13 UTC
        

      






Created attachment 67971 [details] [review]
Bug 19438: Fix sorting by date due in overdues.pl

Test plan:
0) Do not apply the patch
1) Have some overdued checkouts in your database
2) Go to circulation -> overdues (overdues.pl)
3) Try to sort the overdues table by due date and notice it is sorted
alphabetically, not by date
4) Apply the patch
5) Try again and confirm, it is sorted by date

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

    


    


      



        
          Comment 3
        

        
          Marcel de Rooy

        

        
        

        
          2017-10-13 09:31:26 UTC
        

      






Created attachment 68055 [details] [review]
Bug 19438: Fix sorting by date due in overdues.pl

Test plan:
0) Do not apply the patch
1) Have some overdued checkouts in your database
2) Go to circulation -> overdues (overdues.pl)
3) Try to sort the overdues table by due date and notice it is sorted
alphabetically, not by date
4) Apply the patch
5) Try again and confirm, it is sorted by date

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

    


    


      



        
          Comment 4
        

        
          Jonathan Druart

        

        
        

        
          2017-10-13 17:01:54 UTC
        

      






Pushed to master for 17.11, thanks to everybody involved!