This might be a regression, or perhaps it has never worked, but the js-validation for the "Fund" select uses the selector [name="fund_code"] when the element is named "fund_id", correcting the selector fixes this.
Created attachment 67996 [details] [review] Incorrect jQuery selector for fund drop down validation Steps to reproduce: 1. Create a new basket 2. Choose "Add to masket" 3. Choose "From a staged file" 4. Select a file 5. Save without selecting a fund Expected results: A validation error should be shown, and form submit halted. Actual results: No validation error is shown and form submits.
Created attachment 67997 [details] [review] Incorrect jQuery selector for fund drop down validation Steps to reproduce: 1. Create a new basket 2. Choose "Add to masket" 3. Choose "From a staged file" 4. Select a file 5. Save without selecting a fund Expected results: A validation error should be shown, and form submit halted. Actual results: No validation error is shown and form submits. https://bugs.koha-community.org/show_bug.cgi?id=19453 Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 68052 [details] [review] Bug 19453: Incorrect jQuery selector for fund drop down validation Steps to reproduce: 1. Create a new basket 2. Choose "Add to masket" 3. Choose "From a staged file" 4. Select a file 5. Save without selecting a fund Expected results: A validation error should be shown, and form submit halted. Actual results: No validation error is shown and form submits. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
David: Please add Bug [number]: to future patches. Thanks
Pushed to master for 17.11, thanks to everybody involved!
I prefer not to backport to 17.05.x