"Edit [% field.name |html %] field" shows up in translations for items-search_fields.tt Line 80
Created attachment 74283 [details] [review] Bug 19479: Display price in basket group formatted according to CurrencyFormat syspref using templates. On the page acqui/basketgroup.pl the prices of baskets should be shown formatted according to the selected CurrencyFormat syspref, with no currency symbol or code. Test plan: 1) Create a basket with items in it worth more than 1000 currency units. 2) Close the basket. 3) Go to acqui/basketgroup.pl page and check that the price format matches the current CurrencyFormat syspref. 4) Go to Administration and change CurrencyFormat syspref to one of the other available options and recheck step 3. Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Fixed some tabs.
Comment on attachment 74283 [details] [review] Bug 19479: Display price in basket group formatted according to CurrencyFormat syspref using templates. Wrong bug number, sorry!
Created attachment 86593 [details] [review] Bug 19497: Removed title (tooltip) from Edit button in items_search_fields.tt This patch removes the tooltip that appears when hovering over the Edit button of Item Search Fields in the staff client. This was done for consistency reasons, including that this tooltip is not translated and tooltips do not appear to be on the majority of buttons in the staff client. Test plan: 1) In Home->Administration->Item search fields create a new search field if you haven't got any already 2) Observe the tooltip that appears when hovering over the Edit button in the Item serach fields table. 3) Apply the patch and observe that the tool tip no longer appears. Sponsored-by: Catalyst IT
Created attachment 87481 [details] [review] Bug 19497: Removed title (tooltip) from Edit button in items_search_fields.tt This patch removes the tooltip that appears when hovering over the Edit button of Item Search Fields in the staff client. This was done for consistency reasons, including that this tooltip is not translated and tooltips do not appear to be on the majority of buttons in the staff client. Test plan: 1) In Home->Administration->Item search fields create a new search field if you haven't got any already 2) Observe the tooltip that appears when hovering over the Edit button in the Item serach fields table. 3) Apply the patch and observe that the tool tip no longer appears. Sponsored-by: Catalyst IT Signed-off-by: Michal Denar <black23@gmail.com>
Created attachment 87510 [details] [review] Bug 19497: Removed title (tooltip) from Edit button in items_search_fields.tt This patch removes the tooltip that appears when hovering over the Edit button of Item Search Fields in the staff client. This was done for consistency reasons, including that this tooltip is not translated and tooltips do not appear to be on the majority of buttons in the staff client. Test plan: 1) In Home->Administration->Item search fields create a new search field if you haven't got any already 2) Observe the tooltip that appears when hovering over the Edit button in the Item serach fields table. 3) Apply the patch and observe that the tool tip no longer appears. Sponsored-by: Catalyst IT Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Nice simple fix.. Passing QA
Awesome work all! Pushed to master for 19.05
Pushed to 18.11.x for 18.11.05
backported to 18.05.x for 18.05.12
Pushed to 17.11.x for 17.11.18