Choose 'Holds Koha module' in the form displays 'Reserves module' in the tools/letter.pl page.
That is because the module name on the summary table is not translated.
Created attachment 77724 [details] [review] Bug 19500: Make module names on letters overview page translatable While the module pull down on adding and editing a letter is written out and fully translatable, the overview page showed the internal 'module code'. Patch also renames the "Members" module into the "Patrons" module to match Koha's terminology. To test: - Before applying the patch: - Add or edit a notice, look at the pull down for module - Go back to the overview page - Verify the module names don't match - Apply the patch: - Check again, pull downs should now match - Verify that Members is now Patrons everywhere
Created attachment 77815 [details] [review] Bug 19500: Make module names on letters overview page translatable While the module pull down on adding and editing a letter is written out and fully translatable, the overview page showed the internal 'module code'. Patch also renames the "Members" module into the "Patrons" module to match Koha's terminology. To test: - Before applying the patch: - Add or edit a notice, look at the pull down for module - Go back to the overview page - Verify the module names don't match - Apply the patch: - Check again, pull downs should now match - Verify that Members is now Patrons everywhere Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Should not we surround the strings with spans?
(In reply to Jonathan Druart from comment #4) > Should not we surround the strings with spans? We could, but it's not necessary. The text will show up in the po file, because it's inside a parsed html element: <td> It will show up as one string, which can be good sometimes as it means you have more context. If we add <span> tags, they will all show up separately and might get merged with existing translations. So both versions have advantages.
Created attachment 77860 [details] [review] Bug 19500: (QA follow-up) Add spans to ease translation
Thought a bit more about it - adding the spans will help translation more, as it will make them match with the strings from the pull down list.
Created attachment 77987 [details] [review] Bug 19500: Make module names on letters overview page translatable While the module pull down on adding and editing a letter is written out and fully translatable, the overview page showed the internal 'module code'. Patch also renames the "Members" module into the "Patrons" module to match Koha's terminology. To test: - Before applying the patch: - Add or edit a notice, look at the pull down for module - Go back to the overview page - Verify the module names don't match - Apply the patch: - Check again, pull downs should now match - Verify that Members is now Patrons everywhere Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 77988 [details] [review] Bug 19500: (QA follow-up) Add spans to ease translation Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 77989 [details] [review] Bug 19500: Add missing span for 'other' To stay consistent in the DOM structure it would make sense to have it there as well Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Awesome work all! Pushed to master for 18.11
Pushed to 18.05.x for 18.05.03
Pushed to 17.11.x for 17.11.11