Some libraries would like to allow arbitrary lists to be used by all librarians with the 'manage_patron_lists' permission.
Created attachment 75872 [details] [review] Bug 19524: Update database
Created attachment 75873 [details] [review] Bug 19524: Share patron lists between staff Some libraries would like to allow arbitrary lists to be used by all librarians with the 'manage_patron_lists' permission. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Create or find two patrons with the manage_patron_lists permission 4) Using the first patron, create two new lists, mark one of them as shared 5) Log in as the second patron, browse to the patron lists page 6) Note the second patron can view, add and remove patrons from the shared list owned by the first patron
Created attachment 75874 [details] [review] Bug 19524: Update Schema files
Patch tested with a sandbox, by George Williams <george@nekls.org>
Created attachment 75878 [details] [review] Bug 19524: Update database Signed-off-by: George Williams <george@nekls.org>
Created attachment 75879 [details] [review] Bug 19524: Share patron lists between staff Some libraries would like to allow arbitrary lists to be used by all librarians with the 'manage_patron_lists' permission. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Create or find two patrons with the manage_patron_lists permission 4) Using the first patron, create two new lists, mark one of them as shared 5) Log in as the second patron, browse to the patron lists page 6) Note the second patron can view, add and remove patrons from the shared list owned by the first patron Signed-off-by: George Williams <george@nekls.org>
Created attachment 75880 [details] [review] Bug 19524: Update Schema files Signed-off-by: George Williams <george@nekls.org>
Created attachment 75891 [details] [review] Bug 19524: Update database Signed-off-by: George Williams <george@nekls.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 75892 [details] [review] Bug 19524: Share patron lists between staff Some libraries would like to allow arbitrary lists to be used by all librarians with the 'manage_patron_lists' permission. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Create or find two patrons with the manage_patron_lists permission 4) Using the first patron, create two new lists, mark one of them as shared 5) Log in as the second patron, browse to the patron lists page 6) Note the second patron can view, add and remove patrons from the shared list owned by the first patron Signed-off-by: George Williams <george@nekls.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 75893 [details] [review] Bug 19524: Update Schema files Signed-off-by: George Williams <george@nekls.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
+ logged_in_user => $loggedinuser, You should not do that, a Koha::Patron object is already passed using this variable name in C4::Auth
Created attachment 76992 [details] [review] Bug 19524: Use existing logged_in_user variable
Awesome work all! Pushed to master for 18.11
Enhancement, not backporting to 18.05.x series.
This reads like quite a behavior chance - moving things from being private to be shared. Would be good to have some text for the release notes.
Hm, there is a new field 'shared', but it's not mentioned in the test plan?
(In reply to Katrin Fischer from comment #15) > This reads like quite a behavior chance - moving things from being private > to be shared. Would be good to have some text for the release notes. I have since tested this. As "Shared" is an opt-in on any list, this works well.