Testing Rancor gave me: Odd number of elements in anonymous hash at /usr/share/koha/masterclone/svc/bib line 69. Odd number of elements in anonymous hash at /usr/share/koha/masterclone/svc/bib line 118. Odd number of elements in anonymous hash at /usr/share/koha/masterclone/svc/bib line 69. Called in koha-tmpl/intranet-tmpl/lib/koha/cateditor/koha-backend.js
Created attachment 68673 [details] [review] Bug 19536: Odd number of elements in anonymous hash in svc/bib Resolve: Odd number of elements in anonymous hash at svc/bib line 69. Odd number of elements in anonymous hash at svc/bib line 118. You can see such warnings when testing the Rancor editor. Replacing url_param by param in fetch_bib since it is a GET call. Not sure about doing the same in update_bib since that is a POST. The scalar context will resolve the odd number warns. Adding a scalar in svc/new_bib too. Test plan: Try URL /cgi-bin/koha/svc/bib/[number] with and without the patch.
Created attachment 68800 [details] [review] Bug 19536: Odd number of elements in anonymous hash in svc/bib Resolve: Odd number of elements in anonymous hash at svc/bib line 69. Odd number of elements in anonymous hash at svc/bib line 118. You can see such warnings when testing the Rancor editor. Replacing url_param by param in fetch_bib since it is a GET call. Not sure about doing the same in update_bib since that is a POST. The scalar context will resolve the odd number warns. Adding a scalar in svc/new_bib too. Test plan: Try URL /cgi-bin/koha/svc/bib/[number] with and without the patch. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 69128 [details] [review] Bug 19536: Odd number of elements in anonymous hash in svc/bib Resolve: Odd number of elements in anonymous hash at svc/bib line 69. Odd number of elements in anonymous hash at svc/bib line 118. You can see such warnings when testing the Rancor editor. Replacing url_param by param in fetch_bib since it is a GET call. Not sure about doing the same in update_bib since that is a POST. The scalar context will resolve the odd number warns. Adding a scalar in svc/new_bib too. Test plan: Try URL /cgi-bin/koha/svc/bib/[number] with and without the patch. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Pushed to master for 17.11, thanks to everybody involved!