Steps to reproduce: - On the Circulation and fine rules page - Empty the value of 'Current on-site checkouts allowed' and save - Notice 'Unlimited' shows on the saved rule. - Click edit => FAIL: the 'Unlimited' string displays intead of the empty string. This was introduced by bug 18857
Created attachment 68719 [details] [review] Bug 19539: Fix column index shift in cirulation rules This patch fixes an index shift introduced by bug 18857 when it introduced a new column. To test: - On the Circulation and fine rules page - Empty the value of 'Current on-site checkouts allowed' and save - Notice 'Unlimited' shows on the saved rule. - Click edit => FAIL: the 'Unlimited' string displays instead of the empty string on the editing row. - Apply this patch - Re-open the circ rules page - Click edit => SUCCESS: An empty string fills the 'Unlimited' fields - Sign off :-D
Created attachment 68789 [details] [review] Bug 19539: Fix column index shift in cirulation rules This patch fixes an index shift introduced by bug 18857 when it introduced a new column. To test: - On the Circulation and fine rules page - Empty the value of 'Current on-site checkouts allowed' and save - Notice 'Unlimited' shows on the saved rule. - Click edit => FAIL: the 'Unlimited' string displays instead of the empty string on the editing row. - Apply this patch - Re-open the circ rules page - Click edit => SUCCESS: An empty string fills the 'Unlimited' fields - Sign off :-D Signed-off-by: David Bourgault <david.bourgault@inlibro.com>
Created attachment 68846 [details] [review] Bug 19539: Fix column index shift in cirulation rules This patch fixes an index shift introduced by bug 18857 when it introduced a new column. To test: - On the Circulation and fine rules page - Empty the value of 'Current on-site checkouts allowed' and save - Notice 'Unlimited' shows on the saved rule. - Click edit => FAIL: the 'Unlimited' string displays instead of the empty string on the editing row. - Apply this patch - Re-open the circ rules page - Click edit => SUCCESS: An empty string fills the 'Unlimited' fields - Sign off :-D Signed-off-by: David Bourgault <david.bourgault@inlibro.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 68847 [details] [review] Bug 19539: (follow-up) Fix column index shift in cirulation rules Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 68879 [details] [review] Bug 19539: Fix column index shift in cirulation rules This patch fixes an index shift introduced by bug 18857 when it introduced a new column. To test: - On the Circulation and fine rules page - Empty the value of 'Current on-site checkouts allowed' and save - Notice 'Unlimited' shows on the saved rule. - Click edit => FAIL: the 'Unlimited' string displays instead of the empty string on the editing row. - Apply this patch - Re-open the circ rules page - Click edit => SUCCESS: An empty string fills the 'Unlimited' fields - Sign off :-D Signed-off-by: David Bourgault <david.bourgault@inlibro.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 68880 [details] [review] Bug 19539: (follow-up) Fix column index shift in cirulation rules Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 68883 [details] [review] Bug 19539: (follow-up) Fix column index shift in cirulation rules Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Pushed to master for 17.11, thanks to everybody involved!
Bug 18857 not in 17.05.x