150112 Sensitive form field has not disabled autocomple
Created attachment 68901 [details] [review] Bug 19570: Add autocomplete='off' for login forms at the opac
Created attachment 68981 [details] [review] Bug 19570: Add autocomplete to opac-main as well To confirm all the files were modified for opac, typed this: $ git grep -i password | grep opac | grep -v "[.]po:" | grep "opac[^/]*[.]tt:" | cut -f1 -d: | sort -u The follow output was handled as follows: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-auth.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-passwd.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-registration-confirmation.tt These were already done in the first patch. koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-password-recovery.tt This already had the autocomplete modification. koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt This was a false-find. There was no modification necessary. koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-main.tt This is the modal login in. This patch amends it.
Created attachment 69217 [details] [review] Bug 19570: Add autocomplete='off' for login forms at the opac Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 69218 [details] [review] Bug 19570: Add autocomplete to opac-main as well To confirm all the files were modified for opac, typed this: $ git grep -i password | grep opac | grep -v "[.]po:" | grep "opac[^/]*[.]tt:" | cut -f1 -d: | sort -u The follow output was handled as follows: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-auth.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-passwd.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-registration-confirmation.tt These were already done in the first patch. koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-password-recovery.tt This already had the autocomplete modification. koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt This was a false-find. There was no modification necessary. koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-main.tt This is the modal login in. This patch amends it. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 69373 [details] [review] Bug 19570: Add autocomplete='off' for login forms at the opac Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 69374 [details] [review] Bug 19570: Add autocomplete to opac-main as well To confirm all the files were modified for opac, typed this: $ git grep -i password | grep opac | grep -v "[.]po:" | grep "opac[^/]*[.]tt:" | cut -f1 -d: | sort -u The follow output was handled as follows: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-auth.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-passwd.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-registration-confirmation.tt These were already done in the first patch. koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-password-recovery.tt This already had the autocomplete modification. koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt This was a false-find. There was no modification necessary. koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-main.tt This is the modal login in. This patch amends it. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 69654 [details] [review] Bug 19570: Add autocomplete='off' for login forms at the opac Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 69655 [details] [review] Bug 19570: Add autocomplete to opac-main as well To confirm all the files were modified for opac, typed this: $ git grep -i password | grep opac | grep -v "[.]po:" | grep "opac[^/]*[.]tt:" | cut -f1 -d: | sort -u The follow output was handled as follows: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-auth.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-passwd.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-registration-confirmation.tt These were already done in the first patch. koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-password-recovery.tt This already had the autocomplete modification. koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt This was a false-find. There was no modification necessary. koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-main.tt This is the modal login in. This patch amends it. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Pushed to 16.11.x will be in 16.11.15
Pushed to stable for 17.11.01
Pushed to 17.05.x for 17.05.07
Pushed to master for 18.05, thanks to everybody involved!