Add “Write off selected” button
Changed title to differentiate between this bug and bug 11210.
Yes please! This would be very useful when working with patrons with lots of fines, etc. when you don't want to writeoff all of their outstanding fines.
Created attachment 74941 [details] [review] Bug 19617: Allow 'writeoff of selected' This patch adds a writeoff equivilent to 'Pay selected' Test Plan: 1) Apply this patch 2) Find a patron with fines 3) On the "Pay fines" tab, select one or more fines and use the "Write off selected" button. 4) Note the fine amount you used was written off for those fines.
Test Plan: 1) Apply this patch 2) Find a patron with fines 3) On the "Pay fines" tab, select one or more fines and use the "Write off selected" button. 4) Note the fine amount you used was written off for those fines. Works for me! Thanks, Kyle!
Created attachment 75702 [details] [review] Bug 19617: Allow 'writeoff of selected' This patch adds a writeoff equivilent to 'Pay selected' Test Plan: 1) Apply this patch 2) Find a patron with fines 3) On the "Pay fines" tab, select one or more fines and use the "Write off selected" button. 4) Note the fine amount you used was written off for those fines. Signed-off-by: Kyle M Hall <kyle@bywatetsolutions.com> Signed-off-by: Martha Fuerst <mfuerst@hmcpl.org>
CONFLICT (content): Merge conflict in members/pay.pl
Created attachment 76450 [details] [review] Bug 19617: Allow 'writeoff of selected' This patch adds a writeoff equivilent to 'Pay selected' Test Plan: 1) Apply this patch 2) Find a patron with fines 3) On the "Pay fines" tab, select one or more fines and use the "Write off selected" button. 4) Note the fine amount you used was written off for those fines. Signed-off-by: Kyle M Hall <kyle@bywatetsolutions.com> Signed-off-by: Martha Fuerst <mfuerst@hmcpl.org>
Kyle, I've tested the patches and they work as expected. All good :-D My only doubt is about terminology. I know the 'Writeoff' value is used on the offset types, but at least on the UI we should use a common way of writing it. I've found: - Write off - Writeoff And then I mostly found references to 'Write-off' everywhere on the internet. Certainly not a big deal, but worth fixing on this bug.
Created attachment 76638 [details] [review] Bug 19617: Allow 'writeoff of selected' This patch adds a writeoff equivilent to 'Pay selected' Test Plan: 1) Apply this patch 2) Find a patron with fines 3) On the "Pay fines" tab, select one or more fines and use the "Write off selected" button. 4) Note the fine amount you used was written off for those fines. Signed-off-by: Kyle M Hall <kyle@bywatetsolutions.com> Signed-off-by: Martha Fuerst <mfuerst@hmcpl.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 76639 [details] [review] Bug 19617: (QA follow-up) Fix typo for type Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Awesome work all! Pushed to master for 18.11
Enhancement, not backporting to 18.05.x series.
*** Bug 14208 has been marked as a duplicate of this bug. ***