Bug 1962 - Add fine notification during check-in
Summary: Add fine notification during check-in
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: 3.4
Hardware: PC All
: PATCH-Sent (DO NOT USE) enhancement (vote)
Assignee: Katrin Fischer
QA Contact: Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-03-20 07:38 UTC by Chris Cormack
Modified: 2012-10-25 23:03 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Patch for returns.pl and returns.tmpl (1.60 KB, patch)
2008-03-20 19:39 UTC, Chris Cormack
Details | Diff | Splinter Review
proposed patch (2.31 KB, patch)
2011-02-22 21:06 UTC, Katrin Fischer
Details | Diff | Splinter Review
Follow up (919 bytes, patch)
2011-03-06 22:03 UTC, Katrin Fischer
Details | Diff | Splinter Review
3.2.x patch (2.36 KB, patch)
2011-03-13 18:42 UTC, Katrin Fischer
Details | Diff | Splinter Review
Patch adding new syspref FineNotifyAtCheckin (16.80 KB, patch)
2011-03-26 19:03 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Cormack 2010-05-21 00:36:37 UTC


---- Reported by dswhite42@yahoo.com 2008-03-20 19:38:37 ----

During the check-in process, Koha doesn't provide any notification to the librarian that a patron owes a fine.  This patch to (KOHADIR)/intranet/cgi-bin/circ/returns.pl and (KOHADIR)/intranet/htdocs/intranet-tmpl/prog/en/modules/circ/returns.tmpl provides a notice for the librarian and link to the fines page, triggered when the delinquent patron's item is checked in.

(patch is against Koha 3.00.00.067 - 3/20/2008 snapshot)



---- Additional Comments From dswhite42@yahoo.com 2008-03-20 19:39:16 ----

Created an attachment
Patch for returns.pl and returns.tmpl





---- Additional Comments From nengard@gmail.com 2009-12-21 13:06:39 ----

When checking in items I still do not see a notice if the patron has a fine - I do however see if the item was overdue.



--- Bug imported by chris@bigballofwax.co.nz 2010-05-21 00:36 UTC  ---

This bug was previously known as _bug_ 1962 at http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=1962
Imported an attachment (id=439)

Actual time not defined. Setting to 0.0
The original reporter of this bug does not have
   an account here. Reassigning to the person who moved
   it here: chris@bigballofwax.co.nz.
   Previous reporter was dswhite42@yahoo.com.
The original submitter of attachment 439 [details] [review] is unknown.
   Reassigning to the person who moved it here: chris@bigballofwax.co.nz.

Comment 1 Katrin Fischer 2011-02-22 12:13:16 UTC
This is still a problem. You can see if the item was overdue, because the date is shown in red. But you don't see if the patron has to pay a fine for it. (borrower category does not have to pay fines, item is overdue but in grace period) So you have to check the account separately. This adds additional steps, is time consuming and easy to forget.
Comment 2 Katrin Fischer 2011-02-22 21:06:00 UTC
Created attachment 3196 [details] [review]
proposed patch

Reformatted patch, applies to current master branch.
Comment 3 Chris Cormack 2011-02-26 06:54:57 UTC
Pushed please test
Comment 4 MJ Ray (software.coop) 2011-03-03 08:36:54 UTC
This bug is mentioned in:
Bug 1962: Add fine notification	during check-in http://lists.koha-community.org/pipermail/koha-patches/2011-February/013915.html
Bug 1962: Add fine notification during	check-in http://lists.koha-community.org/pipermail/koha-patches/2011-February/013914.html
Comment 5 Katrin Fischer 2011-03-06 21:45:25 UTC
The yellow message box also shows up when there is no fine on the patron's account.
Comment 6 Katrin Fischer 2011-03-06 22:03:04 UTC
Created attachment 3254 [details] [review]
Follow up

Follow up - fixing condition. Works for me, plz test.
Comment 7 Chris Cormack 2011-03-11 19:43:55 UTC
Pushed, please test and mark resolved
Comment 8 Katrin Fischer 2011-03-11 22:33:40 UTC
Tested in master.
Comment 9 Katrin Fischer 2011-03-13 18:42:31 UTC
Created attachment 3285 [details] [review]
3.2.x patch
Comment 10 Nicole C. Engard 2011-03-24 23:33:23 UTC
I'd like to see a preference to choose whether this message appears or not.  Some people are complaining because it's making the checkin process take longer and they don't want the warning.
Comment 11 Katrin Fischer 2011-03-25 06:49:34 UTC
Hi Nicole, 

can you suggest a wording for the system preference? Will make it a little easier :)
Comment 12 Nicole C. Engard 2011-03-25 13:24:32 UTC
How about:


FineNotifyAtCheckin - Notify/Don't notify librarians of overdue fines on the items they are checking in.
Comment 13 Katrin Fischer 2011-03-25 13:31:33 UTC
Thx!
Comment 14 Katrin Fischer 2011-03-26 19:03:27 UTC
Created attachment 3438 [details] [review]
Patch adding new syspref FineNotifyAtCheckin

This patch adds a new syspref FineNotifyAtCheckin.

With syspref ON there will be a message when checking in books from
a patron with outstanding fines.

With syspref OFF (default) no message will be shown.
Comment 15 Chris Cormack 2011-03-27 08:20:36 UTC
Pushed, please test