To recreate: 1 - Enable RoutingSerials syspref 2 - Open a patron record 3 - Click through the tabs on the left side of the screen 4 - Note that 'Routing lists' is visible on all screens except 'Holds history'
Created attachment 69132 [details] [review] Bug 19621 - Use preference check on template side to display/not display Routing lists tab Currently we pass a param to control display - the param is a just a check of syspref so can be done directly form template To test: 1 - Enable RoutingSerials syspref 2 - Open a patron record 3 - Click through the tabs on the left side of the screen 4 - Note that 'Routing lists' is visible on all screens except 'Holds history' 5 - Apply patch 6 - 'Routing lists' should now be visible in all tabs.
Created attachment 69171 [details] [review] Bug 19621 - Use preference check on template side to display/not display Routing lists tab Patch applies without issue and functions as described. Signed-off-by: Dilan Johnpullé <dilan@calyx.net.au>
Seems an enh to me
I's argue for bug - it appears on all other tabs and disappears on one, not adding a new page, just fixing to how it 'should' work It does hit a few pages, so fine either way
I agree with Nick - inconsistent behaviour, you don't expect for menu items to go missing when changing the tab.
Created attachment 70091 [details] [review] Bug 19621 - Use preference check on template side to display/not display Routing lists tab Patch applies without issue and functions as described. Signed-off-by: Dilan Johnpullé <dilan@calyx.net.au> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 18.05, thanks to everybody involved!
Awesome work all, pushed to stable for 17.11.02
Pushed to 17.05.x for v17.05.08