Created attachment 69169 [details] Suspended hold message appears in barcode field In Intranet, when we suspend a hold, the message "hold is suspended" appears in a column titled "barcode". Even when the hold is not suspended, that column doesn't show the barcode. I'm guessing it's just a wording problem...
The barcode and callnumber are only visilble, when the hold is waiting or when it's an item level hold. I think the barcode column is misused for status messages - it also shows when the item is waiting. Maybe a separate status column would be better?
(In reply to Katrin Fischer from comment #1) > The barcode and callnumber are only visilble, when the hold is waiting or > when it's an item level hold. I think the barcode column is misused for > status messages - it also shows when the item is waiting. > > Maybe a separate status column would be better? Hi, could you please specify which Holds table you are talking about?
Hi Hayley, it's the holds table in the patrons's account in staff (look at details and checkouts tabs)
Created attachment 86633 [details] [review] Bug 19630: Added Status column to Patron Holds table When a hold has been suspended or is waiting, the status message appears in the Barcode column of the Holds table. This patch fixes this by adding a separate Status column which details the status of the Hold, whether it has been suspended, or is in transit, etc. Test plan: 1) Place an item level hold and a 'Next Available' record level hold for a patron. 2) View the holds in Patrons->Patron details for that Patron in the Check out and Details tabs 3) Suspend one of the holds, and note that the status appears in the barcode column 4) Set a hold to be waiting for pickup, and note the status appears in the barcode column 5) Apply the patch 6) Check the same holds and note that the statuses now appear in the new column called Status, and note that if a hold has status effect that the row reads "Hold has been placed" 7) Verify that this is the case in both the Holds tables (in Check out tab and Details tab) Sponsored-by: Catalyst IT
(In reply to Hayley Mapley from comment #4) > Created attachment 86633 [details] [review] [review] > Bug 19630: Added Status column to Patron Holds table > > When a hold has been suspended or is waiting, the status > message appears in the Barcode column of the Holds table. This patch > fixes this by adding a separate Status column which details the status > of the Hold, whether it has been suspended, or is in transit, etc. > > Test plan: > 1) Place an item level hold and a 'Next Available' record level hold for > a patron. > 2) View the holds in Patrons->Patron details for that Patron in the Check > out and Details tabs > 3) Suspend one of the holds, and note that the status appears in the > barcode column > 4) Set a hold to be waiting for pickup, and note the status appears in > the barcode column > 5) Apply the patch > 6) Check the same holds and note that the statuses now appear in the new > column called Status, and note that if a hold has status effect that the > row reads "Hold has been placed" > 7) Verify that this is the case in both the Holds tables (in Check out > tab and Details tab) > > Sponsored-by: Catalyst IT Note: Step 6 should read "note that id a hold has no status effect", meaning it is not suspended or waiting, etc,. but instead just exists as a hold.
Created attachment 86687 [details] [review] Bug 19630: Added Status column to Patron Holds table When a hold has been suspended or is waiting, the status message appears in the Barcode column of the Holds table. This patch fixes this by adding a separate Status column which details the status of the Hold, whether it has been suspended, or is in transit, etc. Test plan: 1) Place an item level hold and a 'Next Available' record level hold for a patron. 2) View the holds in Patrons->Patron details for that Patron in the Check out and Details tabs 3) Suspend one of the holds, and note that the status appears in the barcode column 4) Set a hold to be waiting for pickup, and note the status appears in the barcode column 5) Apply the patch 6) Check the same holds and note that the statuses now appear in the new column called Status, and note that if a hold has status effect that the row reads "Hold has been placed" 7) Verify that this is the case in both the Holds tables (in Check out tab and Details tab) Sponsored-by: Catalyst IT Signed-off-by: Jose-Mario Monteiro-Santos <jose-mario.monteiro-santos@inLibro.com>
Created attachment 87418 [details] [review] Bug 19630: Added Status column to Patron Holds table When a hold has been suspended or is waiting, the status message appears in the Barcode column of the Holds table. This patch fixes this by adding a separate Status column which details the status of the Hold, whether it has been suspended, or is in transit, etc. Test plan: 1) Place an item level hold and a 'Next Available' record level hold for a patron. 2) View the holds in Patrons->Patron details for that Patron in the Check out and Details tabs 3) Suspend one of the holds, and note that the status appears in the barcode column 4) Set a hold to be waiting for pickup, and note the status appears in the barcode column 5) Apply the patch 6) Check the same holds and note that the statuses now appear in the new column called Status, and note that if a hold has status effect that the row reads "Hold has been placed" 7) Verify that this is the case in both the Holds tables (in Check out tab and Details tab) Sponsored-by: Catalyst IT Signed-off-by: Jose-Mario Monteiro-Santos <jose-mario.monteiro-santos@inLibro.com> Signed-off-by: Michal Denar <black23@gmail.com>
Comment on attachment 87418 [details] [review] Bug 19630: Added Status column to Patron Holds table Review of attachment 87418 [details] [review]: ----------------------------------------------------------------- Hi Hayley, found a small issue, see below. I don't really like the new message to be honest - I feel it's too much to read. Could we go without? Some examples: Hold has been placed Item hasn't been transferred yet from Fairview Hold has been placed Item is waiting here ::: koha-tmpl/intranet-tmpl/prog/js/holds.js @@ +132,5 @@ > + { > + "mDataProp": function( oObj ) { > + var data = ""; > + if ( oObj.suspend != 1 && !oObj.itemtype_limit) { > + data = _("Hold has been placed\n"); Strings in .js files are not picked up by our translation tools. That is the reason the other messages are using variables that are replaced later.
Reading it again: New message = "Hold has been placed" showing up always.
Created attachment 87485 [details] [review] Bug 19630: Removed constant message from Status column Test plan: Same as initial test plan, except that when a hold has no status that the Status column for that hold should be blank instead of saying "Hold has been placed". Sponsored-by: Catalyst IT
Created attachment 87543 [details] [review] Bug 19630: Added Status column to Patron Holds table When a hold has been suspended or is waiting, the status message appears in the Barcode column of the Holds table. This patch fixes this by adding a separate Status column which details the status of the Hold, whether it has been suspended, or is in transit, etc. Test plan: 1) Place an item level hold and a 'Next Available' record level hold for a patron. 2) View the holds in Patrons->Patron details for that Patron in the Check out and Details tabs 3) Suspend one of the holds, and note that the status appears in the barcode column 4) Set a hold to be waiting for pickup, and note the status appears in the barcode column 5) Apply the patch 6) Check the same holds and note that the statuses now appear in the new column called Status, and note that if a hold has status effect that the row reads "Hold has been placed" 7) Verify that this is the case in both the Holds tables (in Check out tab and Details tab) Sponsored-by: Catalyst IT Signed-off-by: Jose-Mario Monteiro-Santos <jose-mario.monteiro-santos@inLibro.com> Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com>
Created attachment 87544 [details] [review] Bug 19630: Removed constant message from Status column Test plan: Same as initial test plan, except that when a hold has no status that the Status column for that hold should be blank instead of saying "Hold has been placed". Sponsored-by: Catalyst IT Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com>
Created attachment 87556 [details] [review] Bug 19630: Added Status column to Patron Holds table When a hold has been suspended or is waiting, the status message appears in the Barcode column of the Holds table. This patch fixes this by adding a separate Status column which details the status of the Hold, whether it has been suspended, or is in transit, etc. Test plan: 1) Place an item level hold and a 'Next Available' record level hold for a patron. 2) View the holds in Patrons->Patron details for that Patron in the Check out and Details tabs 3) Suspend one of the holds, and note that the status appears in the barcode column 4) Set a hold to be waiting for pickup, and note the status appears in the barcode column 5) Apply the patch 6) Check the same holds and note that the statuses now appear in the new column called Status, and note that if a hold has status effect that the row reads "Hold has been placed" 7) Verify that this is the case in both the Holds tables (in Check out tab and Details tab) Sponsored-by: Catalyst IT Signed-off-by: Jose-Mario Monteiro-Santos <jose-mario.monteiro-santos@inLibro.com> Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 87557 [details] [review] Bug 19630: Removed constant message from Status column Test plan: Same as initial test plan, except that when a hold has no status that the Status column for that hold should be blank instead of saying "Hold has been placed". Sponsored-by: Catalyst IT Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Thx Haley!
Awesome work all! Pushed to master for 19.05
Enhancement, will not be backported to 18.11.x series.