It was found when customizing an instance. The comment makes it clear that it should be a closing tag. http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt;hb=570eb4026642f71e462c7746a9c91721aa9334c1#l725
Created attachment 69336 [details] [review] Bug 19692 : fix unclosed div in opac-shelves.tt Test plan: 1. set syspref OpacKohaUrl to "Show" 2. Log into the OPAC 3. /cgi-bin/koha/opac-shelves.pl 4. Notice that "Powered by Koha" is not in the footer in this page. When on the other tabs it's in the footer (out of .main) 5. Apply this patch 6. Notice that "Powered by Koha" now in the footer in the "your lists" page
Created attachment 69337 [details] [review] Bug 19692 : fix unclosed div in opac-shelves.tt Test plan: 1. set syspref OpacKohaUrl to "Show" 2. Log into the OPAC 3. /cgi-bin/koha/opac-shelves.pl 4. Notice that "Powered by Koha" is not in the footer in this page. When on the other tabs it's in the footer (out of .main) 5. Apply this patch 6. Notice that "Powered by Koha" now in the footer in the "your lists" page Signed-off-by: Dominic Pichette <dominic@inlibro.com>
Created attachment 69376 [details] [review] Bug 19692 : fix unclosed div in opac-shelves.tt Test plan: 1. set syspref OpacKohaUrl to "Show" 2. Log into the OPAC 3. /cgi-bin/koha/opac-shelves.pl 4. Notice that "Powered by Koha" is not in the footer in this page. When on the other tabs it's in the footer (out of .main) 5. Apply this patch 6. Notice that "Powered by Koha" now in the footer in the "your lists" page Signed-off-by: Dominic Pichette <dominic@inlibro.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 69379 [details] [review] Bug 19692 : fix unclosed div in opac-shelves.tt Test plan: 1. set syspref OpacKohaUrl to "Show" 2. Log into the OPAC 3. /cgi-bin/koha/opac-shelves.pl 4. Notice that "Powered by Koha" is not in the footer in this page. When on the other tabs it's in the footer (out of .main) 5. Apply this patch 6. Notice that "Powered by Koha" now in the footer in the "your lists" page Signed-off-by: Dominic Pichette <dominic@inlibro.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
I've changed the author of the commit to Simon Pouchol (the work was on my machine). That might be their first contribution to the codebase, that's why it might matters :)
Patch has been pushed to master for 18.05. Congratulations Simon for your first patch in!
Hooray :D
Pushed to stable for 17.11.01, awesome work all!
Pushed to 17.05.x, will be in v17.05.07