Created attachment 69552 [details] Strange message while upgrading to 17.12.00.000 Upgrading to current master (17.12.00.0000) displays a strange message (seems to be encoding problem). See screenshot from Firefox ESR 45.3.0
That will be some problem encoding the macrons in the update text.
(I am not sure about that I guess this has been added by bug 13793)
Created attachment 69980 [details] [review] Bug 19756: Fix encoding issues during the update DB process To display the output of the updatedatabase.pl under Plack, we redirect the output to a temporary file, read it, then display it. We need to open it specifying the correct encoding (utf-8). Test plan: 1. MariaDB [koha_kohadev]> update systempreferences set value="17.1100000" where variable="version"; 2. restart plack 3. Login 4. Make the update from the interface => Without this patch you will see encoding issue: Upgrade to 17.12.00.000 done (TÄ tÅia, tÄ haumatia) => With this patch applied you will see : Upgrade to 17.12.00.000 done (Tē tōia, tē haumatia)
Created attachment 69983 [details] [review] Bug 19756: Fix encoding issues during the update DB process To display the output of the updatedatabase.pl under Plack, we redirect the output to a temporary file, read it, then display it. We need to open it specifying the correct encoding (utf-8). Test plan: 1. MariaDB [koha_kohadev]> update systempreferences set value="17.1100000" where variable="version"; 2. restart plack 3. Login 4. Make the update from the interface => Without this patch you will see encoding issue: Upgrade to 17.12.00.000 done (TÄ tÅia, tÄ haumatia) => With this patch applied you will see : Upgrade to 17.12.00.000 done (Tē tōia, tē haumatia) Signed-off-by: Liz Rea <liz@catalyst.net.nz>
Created attachment 70040 [details] [review] Bug 19756: Fix encoding issues during the update DB process To display the output of the updatedatabase.pl under Plack, we redirect the output to a temporary file, read it, then display it. We need to open it specifying the correct encoding (utf-8). Test plan: 1. MariaDB [koha_kohadev]> update systempreferences set value="17.1100000" where variable="version"; 2. restart plack 3. Login 4. Make the update from the interface => Without this patch you will see encoding issue: Upgrade to 17.12.00.000 done (TÄ tÅia, tÄ haumatia) => With this patch applied you will see : Upgrade to 17.12.00.000 done (Tē tōia, tē haumatia) Signed-off-by: Liz Rea <liz@catalyst.net.nz> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Pushed to master for 18.05, thanks to everybody involved!
Awesome work all, pushed to stable for 17.11.02
Pushed to 17.05.x for v17.05.08