When placing a hold for a patron whose pickup library and home library are different, the message displayed only shows the branch code and not the branch name. To reproduce: Go to place a hold on an item for a patron whose home library is different to that of the item. The message: 'Pickup library is different...' will be displayed but the branch name is missing.
Created attachment 69594 [details] [review] When placing a hold for a patron whose pickup library and home library are different, the message displayed only shows the branch code and not the branch name. This patch displays the branch name as well as the branch code. To test: 1. Search for an item 2. Click 'place hold' 3. Enter patron name/card number for a patron whose home library is different to the item's 4. Note the message displayed only shows the branch code but not the name 5. Apply Patch 6. Repeat 1-3 7. Message should not also display the branch name
Created attachment 69605 [details] [review] Bug 19769: 'Pickup library is different' message does not display library branch name when placing hold When placing a hold for a patron whose pickup library and home library are different, the message displayed only shows the branch code and not the branch name. This patch displays the branch name as well as the branch code. To test: 1. Search for an item 2. Click 'place hold' 3. Enter patron name/card number for a patron whose home library is different to the item's 4. Note the message displayed only shows the branch code but not the name 5. Apply Patch 6. Repeat 1-3 7. Message should not also display the branch name https://bugs.koha-community.org/show_bug.cgi?id=19769 Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 69609 [details] [review] Bug 19769: 'Pickup library is different' message does not display library branch name when placing hold When placing a hold for a patron whose pickup library and home library are different, the message displayed only shows the branch code and not the branch name. This patch displays the branch name as well as the branch code. To test: 1. Search for an item 2. Click 'place hold' 3. Enter patron name/card number for a patron whose home library is different to the item's 4. Note the message displayed only shows the branch code but not the name 5. Apply Patch 6. Repeat 1-3 7. Message should now also display the branch name https://bugs.koha-community.org/show_bug.cgi?id=19769 Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Caused by commit df97814f3034a3d5015546c4eca21f08ae951e37 Bug 15758: Koha::Libraries - Remove GetBranches (certainly a bad merge conflict)
Pushed to master for 18.05, thanks to everybody involved!
Awesome work all! Pushed to stable for 17.11.01