+++ This bug was initially created as a clone of Bug #19777 +++ In order to conform to best practices for performance staff client template javascript should be in the footer instead of the header. This patch will do so for even more of the serials templates.
Created attachment 69651 [details] [review] Bug 19778: Move template JavaScript to the footer: Serials, part 4 This patch modifies more and more staff client serials templates so that JavaScript is included in the footer instead of the header. This patch adds a new JavaScript include, showpredictionpattern.js, which is used by subscription-add.tt and subscription-numberpatterns.tt. it also adds subscription-add.js, moving most of the JS embedded in subscription-add.tt into an external file. To test, apply the patch and test the JavaScript-driven features of the modified templates: All button controls, DataTables functionality, tabs, etc. - Serials -> New subscription - Date pickers - Popup search windows for vendors and bibliographic records - Next / Previous buttons - Form validation - Prediction pattern operations Test with new subscriptions, editing existing subscriptions, and duplicating subscriptions. - Serials -> Manage Numbering Patterns - Datatable - Delete confirmation -> Edit - Datepicker, test pattern - Serials -> Manage frequencies - Delete confirmation -> Edit - Form validation - Serials -> Subscription details -> Planning tab -> Edit history -> Datepicker - Serials -> Subscription details -> Renew - Datepicker
Created attachment 69663 [details] [review] Bug 19778: Move template JavaScript to the footer: Serials, part 4 This patch modifies more and more staff client serials templates so that JavaScript is included in the footer instead of the header. This patch adds a new JavaScript include, showpredictionpattern.js, which is used by subscription-add.tt and subscription-numberpatterns.tt. it also adds subscription-add.js, moving most of the JS embedded in subscription-add.tt into an external file. To test, apply the patch and test the JavaScript-driven features of the modified templates: All button controls, DataTables functionality, tabs, etc. - Serials -> New subscription - Date pickers - Popup search windows for vendors and bibliographic records - Next / Previous buttons - Form validation - Prediction pattern operations Test with new subscriptions, editing existing subscriptions, and duplicating subscriptions. - Serials -> Manage Numbering Patterns - Datatable - Delete confirmation -> Edit - Datepicker, test pattern - Serials -> Manage frequencies - Delete confirmation -> Edit - Form validation - Serials -> Subscription details -> Planning tab -> Edit history -> Datepicker - Serials -> Subscription details -> Renew - Datepicker Signed-off-by: Dominic Pichette <dominic@inlibro.com>
Created attachment 69792 [details] [review] Bug 19778: Move template JavaScript to the footer: Serials, part 4 This patch modifies more and more staff client serials templates so that JavaScript is included in the footer instead of the header. This patch adds a new JavaScript include, showpredictionpattern.js, which is used by subscription-add.tt and subscription-numberpatterns.tt. it also adds subscription-add.js, moving most of the JS embedded in subscription-add.tt into an external file. To test, apply the patch and test the JavaScript-driven features of the modified templates: All button controls, DataTables functionality, tabs, etc. - Serials -> New subscription - Date pickers - Popup search windows for vendors and bibliographic records - Next / Previous buttons - Form validation - Prediction pattern operations Test with new subscriptions, editing existing subscriptions, and duplicating subscriptions. - Serials -> Manage Numbering Patterns - Datatable - Delete confirmation -> Edit - Datepicker, test pattern - Serials -> Manage frequencies - Delete confirmation -> Edit - Form validation - Serials -> Subscription details -> Planning tab -> Edit history -> Datepicker - Serials -> Subscription details -> Renew - Datepicker Signed-off-by: Dominic Pichette <dominic@inlibro.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Pushed to master for 18.05, thanks to everybody involved!
Awesome work all! Enhancement, not backporting for 17.11