In order to conform to best practices for performance staff client template javascript should be in the footer instead of the header. This patch will do so for some of the authorities templates.
Created attachment 69662 [details] [review] Bug 19785: Move template JavaScript to the footer: Authorities, part 1 This patch modifies even more staff client authorities templates so that JavaScript is included in the footer instead of the header. To test, apply the patch and test the JavaScript-driven features of the modified templates: All button controls, DataTables functionality, tabs, etc. - Authorities - New from Z39.50 -> Search -> Results - New from Z39.50 - Deletion confirmation - Merge records -> Merge - Tabs - Tag selection -> Authority detail - Tabs - Deletion confirmation - New from Z39.50
I am not able to delete an authority from the results page. The confirmation window is shown but when I come back the authority is still there. Is there an Ajax call that is not working here or is it a problem from my DB maybe? Otherwise, everything works fine.
Hi Dominic, if you find something wrong with a patch, please switch to 'failed QA', thx!
Created attachment 69683 [details] [review] Bug 19785: Move template JavaScript to the footer: Authorities, part 1 This patch modifies even more staff client authorities templates so that JavaScript is included in the footer instead of the header. To test, apply the patch and test the JavaScript-driven features of the modified templates: All button controls, DataTables functionality, tabs, etc. - Authorities - New from Z39.50 -> Search -> Results - New from Z39.50 - Deletion confirmation - Merge records -> Merge - Tabs - Tag selection -> Authority detail - Tabs - Deletion confirmation - New from Z39.50
There seems to be an issue with suggestions from cache (not sure how to call them, when pressing down arrow or double-clicking on a text input to show previously used text) on the Z39.50 search form. When double clicking on a text field, these options immediately hide and have weird behavior overall. Might be unrelated to this patch ?
Sorry Simon, I don't understand the problem you're having!
Seems like it's a bug on Firefox, totally unrelated to this patch my bad.
Created attachment 70565 [details] [review] Bug 19785: Move template JavaScript to the footer: Authorities, part 1 This patch modifies even more staff client authorities templates so that JavaScript is included in the footer instead of the header. To test, apply the patch and test the JavaScript-driven features of the modified templates: All button controls, DataTables functionality, tabs, etc. - Authorities - New from Z39.50 -> Search -> Results - New from Z39.50 - Deletion confirmation - Merge records -> Merge - Tabs - Tag selection -> Authority detail - Tabs - Deletion confirmation - New from Z39.50
Created attachment 71390 [details] [review] Bug 19785: Move template JavaScript to the footer: Authorities, part 1 This patch modifies even more staff client authorities templates so that JavaScript is included in the footer instead of the header. To test, apply the patch and test the JavaScript-driven features of the modified templates: All button controls, DataTables functionality, tabs, etc. - Authorities - New from Z39.50 -> Search -> Results - New from Z39.50 - Deletion confirmation - Merge records -> Merge - Tabs - Tag selection -> Authority detail - Tabs - Deletion confirmation - New from Z39.50
Hullo, when merging two authorities (merge.pl) I get: ReferenceError: _ is not defined merge.pl:54:9
Created attachment 71553 [details] [review] Bug 19785: Move template JavaScript to the footer: Authorities, part 1 This patch modifies even more staff client authorities templates so that JavaScript is included in the footer instead of the header. To test, apply the patch and test the JavaScript-driven features of the modified templates: All button controls, DataTables functionality, tabs, etc. - Authorities - New from Z39.50 -> Search -> Results - New from Z39.50 - Deletion confirmation - Merge records -> Merge - Tabs - Tag selection -> Authority detail - Tabs - Deletion confirmation - New from Z39.50
Created attachment 71601 [details] [review] Bug 19785: Move template JavaScript to the footer: Authorities, part 1 This patch modifies even more staff client authorities templates so that JavaScript is included in the footer instead of the header. To test, apply the patch and test the JavaScript-driven features of the modified templates: All button controls, DataTables functionality, tabs, etc. - Authorities - New from Z39.50 -> Search -> Results - New from Z39.50 - Deletion confirmation - Merge records -> Merge - Tabs - Tag selection -> Authority detail - Tabs - Deletion confirmation - New from Z39.50 Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de>
Created attachment 71902 [details] [review] Bug 19785: Move template JavaScript to the footer: Authorities, part 1 This patch modifies even more staff client authorities templates so that JavaScript is included in the footer instead of the header. To test, apply the patch and test the JavaScript-driven features of the modified templates: All button controls, DataTables functionality, tabs, etc. - Authorities - New from Z39.50 -> Search -> Results - New from Z39.50 - Deletion confirmation - Merge records -> Merge - Tabs - Tag selection -> Authority detail - Tabs - Deletion confirmation - New from Z39.50 Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Hi Owen, QA tools complain, but I suspect false positives. Could you please double check? FAIL koha-tmpl/intranet-tmpl/prog/en/modules/authorities/detail.tt FAIL forbidden patterns forbidden pattern: intranet-tmpl should certainly replaced with [% interface %] (line 102) forbidden pattern: Include [% KOHA_VERSION %] in js paths (bug 12904) - May be false positive (line 102) The line in the template is: <script type="text/javascript" src="/intranet-tmpl/lib/jquery/plugins/jquery.jstree_[% KOHA_VERSION %].js"></script>
Created attachment 71916 [details] [review] Bug 19785: Replace intranet-tmpl with [% interface %]
Pushed to master for 18.05, thanks to everybody involved!
Enhancement, not backported for 17.11