Created attachment 69677 [details] [review] Bug 19790: Remove additionalauthors.author from installer files In the upgrade from 2.2 to 3.0 (some time ago already) the table additionalauthors has been dropped. Unfortunately, a reference to this table has not been removed from the MARC framework installer files. This patch clears kohafield for 700$a or 200$g in 18 installer files. Note: The reference to additionalauthors in field kohafield is silently ignored in AddBiblio/ModBiblio since the routines _koha_add_biblio, _koha_add_biblioitem, _koha_modify_biblio and _koha_modify_biblioitem_nonmarc simply do not use it. You can define a Koha to MARC mapping for a biblio/biblioitem field but if the field is not referenced in one of those routines, nothing happens.. Also note that C4::Items::_koha_modify_item does not hardcode all fields and will respond to a new item mapping. Test plan: [1] Run a new install or verify somehow that the change to these sql files is correct. The change is a result of: sed -i -e "s/'additionalauthors.author'/''/g" Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Run a new install with MARC21 and English. This includes the mandatory file marc21_framework_DEFAULT.sql. Verified that 700$a was inserted correctly (without additionalauthors).
Created attachment 69678 [details] [review] Bug 19790: Add a db revision for existing installs Since many installs will still have the additionalauthors kohafield, this patch adds a dbrev in atomicupdate to clear it. Test plan: [1] Run updatedatabase. Check that you see no additionalauthors anymore in marc_subfield_structure.kohafield. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 69679 [details] [review] Bug 19790: Remove additionalauthors.author from installer files In the upgrade from 2.2 to 3.0 (some time ago already) the table additionalauthors has been dropped. Unfortunately, a reference to this table has not been removed from the MARC framework installer files. This patch clears kohafield for 700$a or 200$g in 32 installer files. Note: The reference to additionalauthors in field kohafield is silently ignored in AddBiblio/ModBiblio since the routines _koha_add_biblio, _koha_add_biblioitem, _koha_modify_biblio and _koha_modify_biblioitem_nonmarc simply do not use it. You can define a Koha to MARC mapping for a biblio/biblioitem field but if the field is not referenced in one of those routines, nothing happens.. Also note that C4::Items::_koha_modify_item does not hardcode all fields and will respond to a new item mapping. Test plan: [1] Run a new install or verify somehow that the change to these sql files is correct. The change is a result of: sed -i -e "s/'additionalauthors.author'/''/g" Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Run a new install with MARC21 and English. This includes the mandatory file marc21_framework_DEFAULT.sql. Verified that 700$a was inserted correctly (without additionalauthors).
Created attachment 69680 [details] [review] Bug 19790: Add a db revision for existing installs Since many installs may still have the additionalauthors kohafield, this patch adds a dbrev in atomicupdate to clear it. Test plan: [1] Run updatedatabase. Check that you see no additionalauthors anymore in marc_subfield_structure.kohafield. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Installed first without the patch, then with the patch. The second time around, no "additionalauthors" appeared in my database dump. However, minor nitpick: setting a value to NULL in your atomicupdate script is not the same as setting it to the empty string ''. Perhaps you'd want change your updatedb script in order to have the same end result, whether you're installing fresh or running updatedatabase over existing data.
Created attachment 71402 [details] [review] Bug 19790: Remove additionalauthors.author from installer files In the upgrade from 2.2 to 3.0 (some time ago already) the table additionalauthors has been dropped. Unfortunately, a reference to this table has not been removed from the MARC framework installer files. This patch clears kohafield for 700$a or 200$g in 32 installer files. Note: The reference to additionalauthors in field kohafield is silently ignored in AddBiblio/ModBiblio since the routines _koha_add_biblio, _koha_add_biblioitem, _koha_modify_biblio and _koha_modify_biblioitem_nonmarc simply do not use it. You can define a Koha to MARC mapping for a biblio/biblioitem field but if the field is not referenced in one of those routines, nothing happens.. Also note that C4::Items::_koha_modify_item does not hardcode all fields and will respond to a new item mapping. Test plan: [1] Run a new install or verify somehow that the change to these sql files is correct. The change is a result of: sed -i -e "s/'additionalauthors.author'/''/g" Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Run a new install with MARC21 and English. This includes the mandatory file marc21_framework_DEFAULT.sql. Verified that 700$a was inserted correctly (without additionalauthors). Signed-off-by: Charles Farmer <charles.farmer@inLibro.com>
Created attachment 71403 [details] [review] Bug 19790: Add a db revision for existing installs Since many installs may still have the additionalauthors kohafield, this patch adds a dbrev in atomicupdate to clear it. Test plan: [1] Run updatedatabase. Check that you see no additionalauthors anymore in marc_subfield_structure.kohafield. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Charles Farmer <charles.farmer@inLibro.com>
Created attachment 71406 [details] [review] Bug 19790: Remove additionalauthors.author from installer files In the upgrade from 2.2 to 3.0 (some time ago already) the table additionalauthors has been dropped. Unfortunately, a reference to this table has not been removed from the MARC framework installer files. This patch clears kohafield for 700$a or 200$g in 32 installer files. Note: The reference to additionalauthors in field kohafield is silently ignored in AddBiblio/ModBiblio since the routines _koha_add_biblio, _koha_add_biblioitem, _koha_modify_biblio and _koha_modify_biblioitem_nonmarc simply do not use it. You can define a Koha to MARC mapping for a biblio/biblioitem field but if the field is not referenced in one of those routines, nothing happens.. Also note that C4::Items::_koha_modify_item does not hardcode all fields and will respond to a new item mapping. Test plan: [1] Run a new install or verify somehow that the change to these sql files is correct. The change is a result of: sed -i -e "s/'additionalauthors.author'/''/g" Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Run a new install with MARC21 and English. This includes the mandatory file marc21_framework_DEFAULT.sql. Verified that 700$a was inserted correctly (without additionalauthors). Signed-off-by: Charles Farmer <charles.farmer@inLibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 71407 [details] [review] Bug 19790: Add a db revision for existing installs Since many installs may still have the additionalauthors kohafield, this patch adds a dbrev in atomicupdate to clear it. Test plan: [1] Run updatedatabase. Check that you see no additionalauthors anymore in marc_subfield_structure.kohafield. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Charles Farmer <charles.farmer@inLibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
DB update - not trivial :) https://wiki.koha-community.org/wiki/Submitting_A_Patch
Pushed to master for 18.05, thanks to everybody involved!