The sample notice RLIST - Routing list has indeed nothing to do with routing lists, but is a sample template for patrons subscribing to get informed by email about newly arriving issues for their favourite serials. There is no connection to the routing list feature at all - so the name is confusing to a lot of people, even if the hint in the subscription form is correct already. I propose to rename the template (help from native speakers welcome): SERIAL_ALERT - New serial issue
Created attachment 72162 [details] [review] Bug 19794: Rename RLIST notice to SERIAL_ALERT to better reflect its purpose The RLIST sample notice is used to send an email to patrons who have subscribed to be notified when a new issue for a subscription arrives. This is a feature that is totally independent and not related to the use of routing lists. In the GUI however, this was misleading so far. - Rename RLIST to SERIAL_ALERT and fixes the sample notices - Fix explanations in the helf files - Fix name of the module in letters from 'serials (routing list)' to 'serials (new issue)' Note: There is no logic to be changed as the notice template to be used is defined for each subscriptions and this is just the sample notice. I've also opted against a database update, to not interfere with existing installations, reports etc. A patch to the manual will be submitted shortly after this passes QA.
Created attachment 72990 [details] [review] Bug 19794: Rename RLIST notice to SERIAL_ALERT to better reflect its purpose The RLIST sample notice is used to send an email to patrons who have subscribed to be notified when a new issue for a subscription arrives. This is a feature that is totally independent and not related to the use of routing lists. In the GUI however, this was misleading so far. - Rename RLIST to SERIAL_ALERT and fixes the sample notices - Fix explanations in the helf files - Fix name of the module in letters from 'serials (routing list)' to 'serials (new issue)' Note: There is no logic to be changed as the notice template to be used is defined for each subscriptions and this is just the sample notice. I've also opted against a database update, to not interfere with existing installations, reports etc. A patch to the manual will be submitted shortly after this passes QA. Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>
Created attachment 74242 [details] [review] Bug 19794: Rename RLIST notice to SERIAL_ALERT to better reflect its purpose The RLIST sample notice is used to send an email to patrons who have subscribed to be notified when a new issue for a subscription arrives. This is a feature that is totally independent and not related to the use of routing lists. In the GUI however, this was misleading so far. - Rename RLIST to SERIAL_ALERT and fixes the sample notices - Fix explanations in the helf files - Fix name of the module in letters from 'serials (routing list)' to 'serials (new issue)' Note: There is no logic to be changed as the notice template to be used is defined for each subscriptions and this is just the sample notice. I've also opted against a database update, to not interfere with existing installations, reports etc. A patch to the manual will be submitted shortly after this passes QA. Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Created attachment 74243 [details] [review] Bug 19794: (QA follow-up) Change tab to space Test plan: Run qa tools, it should be happy Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
> Note: There is no logic to be changed as the notice template > to be used is defined for each subscriptions and this is just > the sample notice. I've also opted against a database update, to not > interfere with existing installations, reports etc. Sure? I would update subscription.letter.
(In reply to Jonathan Druart from comment #5) > > Note: There is no logic to be changed as the notice template > > to be used is defined for each subscriptions and this is just > > the sample notice. I've also opted against a database update, to not > > interfere with existing installations, reports etc. > > Sure? > I would update subscription.letter. Hm, can you explain? This only takes effect for new installations as it is now and old ones will be left unchanged. We could, but it won't break anything if we don't, as there is no hardcoded reference to RLIST.
Created attachment 74287 [details] [review] Bug 19794: (follow-up) Add atomic update The update will - change the RLIST notice code to SERIAL_ALERT - adapt the description if it has remained unchanged from 'Routing List' to 'New serial issue' - update subscriptions to use the new notice code
Added a database update as requested by RM.
Comment on attachment 74287 [details] [review] Bug 19794: (follow-up) Add atomic update Review of attachment 74287 [details] [review]: ----------------------------------------------------------------- ::: installer/data/mysql/atomicupdate/bug_19794_update_rlist.sql @@ +1,3 @@ > +UPDATE letter SET code = "SERIAL_ALERT" WHERE code = "RLIST"; > +UPDATE letter SET name = "New serial issue" WHERE name = "Routing List"; > +UPDATE letter SET name = "New serial issue" WHERE name = "Routing List"; This is duplicate. You are missing: UPDATE subscription SET letter = "SERIAL_ALERT" WHERE letter = "RLIST";
Argh, sorry. I tested it all, but silly copy & paste mistake.
Created attachment 74289 [details] [review] Bug 19794: (follow-up) Add atomic update The update will - change the RLIST notice code to SERIAL_ALERT - adapt the description if it has remained unchanged from 'Routing List' to 'New serial issue' - update subscriptions to use the new notice code
Created attachment 74290 [details] [review] Bug 19794: (follow-up) Add atomic update The update will - change the RLIST notice code to SERIAL_ALERT - adapt the description if it has remained unchanged from 'Routing List' to 'New serial issue' - update subscriptions to use the new notice code Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Pushed to master for 18.05, thanks to everybody involved!