When bug 18754 was merged into 16.11 a little mistake crept in. The "Subscripiton from: ..." line now appears twice on the subscription tab on the OPAC detail page. 823 [% END %] 824 <p>Subscription from: [% subscription.histstartdate | $KohaDates %] to:[% IF ( subscription.histenddate ) %] [% subscription.histenddate | $KohaDates %] [% ELSE %] now (current)[% END %]</p> 825 <p class="subscription_dates">Subscription from: [% subscription.histstartdate | $KohaDates %] to:[% IF ( subscription.histenddate ) %] [% subscription.histenddate | $KohaDates %] [% ELSE %] now (current)[% END %]</p> 826 [% IF ( subscription.missinglist ) %] This is where the mistake happened: http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=b0d86d10443809f3762bdac75a59d704f1a3976b Problem is in 16.11 only, doesn't appear in 17.05 and up.
Created attachment 69705 [details] [review] Bug 19796 - Fix doubled up subscription info on OPAC detail page The info "Subscription from..." is showing twice on the subscription tab on the OPAC detail page because of a bad merge. This patch removes the doubled up information. To test: - Add a subscription - Search for the record in the OPAC - Switch to the subscription tab - Verify that the 'Subscription from...' line is repeated - Apply patch - Verify only one line remains and nothing is missing
Created attachment 69932 [details] [review] Bug 19796 - Fix doubled up subscription info on OPAC detail page The info "Subscription from..." is showing twice on the subscription tab on the OPAC detail page because of a bad merge. This patch removes the doubled up information. To test: - Add a subscription - Search for the record in the OPAC - Switch to the subscription tab - Verify that the 'Subscription from...' line is repeated - Apply patch - Verify only one line remains and nothing is missing Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Looks good to me. Moving to Stable status
Pushed to 16.11.x will be in 16.11.15