The option to subscribe to email for newly arrived serial issues is something that people like a lot in Koha - currently this is broken a bit in both versions I tested. For master: To test: - Add a subscription - Make sure you set a notice template for 'notification' on the first page - Go to the record in the OPAC - Subscribe to email notifications from the Subscriptions tab - Go back to the subscription detail page - Click on the 'subscribers' link - Verify that the list shown is empty - Verify that the alert table in the database has the entry for the subscribed patron - Verify that in the OPAC it now asks you to cancel subscription For 16.11: (I can move this to a separate bug if needed) - Follow above test plan until "subscribe..." - Verify that the redirect is to an empty page - Verify that the subscriber link doesn't work - Verify that the link doesn't change to cancel and you can subscribe mulitple times - Verify that the alert table will have multiple entries for your borrowernumber and subscription id
Note: In 16.11.x you can only subscribe form the full history, click 'more details' at the bottom of the subscription page to go there. Also the link will only show, when you are logged in.
I think it stems from this change here: http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=27891cbfe2160a8ed72df384490430d111e6c9e8 <input type="hidden" name="externalid" value="[% externalid %]"> - <input type="hidden" name="alerttype" value="issue"> - <input type="hidden" name="biblionumber" value="[% biblionumber %]"> + <input type="hidden" name="alerttype" value="[% alerttype %]"> + <input type="hidden" name="biblionumber" value="[% biblionumber | html When you check the alert table the type is empty, which explains the problem with the subscribers list display and possibly also the problems appearing in 16.11.x.
I do not recreate what you describe for master. Make sure you have a surname and a firstname: MariaDB [koha_kohadev]> select surname, firstname from borrowers where borrowernumber=51; +---------+-----------+ | surname | firstname | +---------+-----------+ | koha | NULL | +---------+-----------+ MariaDB [koha_kohadev]> select concat(surname, firstname) from borrowers where borrowernumber=51; +----------------------------+ | concat(surname, firstname) | +----------------------------+ | NULL | +----------------------------+
Created attachment 69933 [details] [review] Bug 19797: [16.11.x] Restore alert subscribers This patch fixes a bad conflict between bug 18726 and bug 10357. The alerttype variable was not passed to the template on 16.11.x Test plan: - Add a subscription - Make sure you set a notice template for 'notification' on the first page - Go to the record in the OPAC - Subscribe to email notifications from the Subscriptions tab > More detail - Verify that the alert table in the database has the entry for the subscribed patron - Verify that in the OPAC it now asks you to cancel subscription
Setting to 16.11.x specific, please open another bug report if the behavior is wrong on master as well.
Created attachment 72270 [details] [review] Bug 19797: [16.11.x] Restore alert subscribers This patch fixes a bad conflict between bug 18726 and bug 10357. The alerttype variable was not passed to the template on 16.11.x Test plan: - Add a subscription - Make sure you set a notice template for 'notification' on the first page - Go to the record in the OPAC - Subscribe to email notifications from the Subscriptions tab > More detail - Verify that the alert table in the database has the entry for the subscribed patron - Verify that in the OPAC it now asks you to cancel subscription Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
I will retest master, but this fixes the most important blocker.
Not for master, sending to RMaints queue.
Pushed to 16.11.x will be in 16.11.17