Marking master as version as 17.11 isn't available to select. It seems the itemnumber isn't set in the link/button that prints transfer-slips. To reproduce: 1. Check in available/not on hold item at a non owning library. 2. Press transfer-button. 3. Resulting slips says "Item not found". "Inspect element" in browser for the button indicates that itemnumber is not set: "transfer-slip.pl?transferitem=&branchcode=CPL&op=slip"
This bug may have been caused by commit 6eade474ed3a84a5ba372a26ac27bf9fb4bd2299 Bug 18276: Remove GetBiblioFromItemNumber - Easy ones
Created attachment 69925 [details] [review] Bug 19798: Fix print transfer slip ... and maybe other bugs as well What happens here is that $itemnumber is no longer set when barcode is passed. Test plan: 1. Check in available/not on hold item at a non owning library. 2. Click print slip 3. Item's info must be displayed on the slip
Related with bug 19840
Patch tested with a sandbox, by Björn Nylén <bjorn.nylen@ub.lu.se>
Created attachment 70169 [details] [review] Bug 19798: Fix print transfer slip ... and maybe other bugs as well What happens here is that $itemnumber is no longer set when barcode is passed. Test plan: 1. Check in available/not on hold item at a non owning library. 2. Click print slip 3. Item's info must be displayed on the slip Signed-off-by: Björn Nylén <bjorn.nylen@ub.lu.se> Signed-off-by: Björn Nylén <bjorn.nylen@ub.lu.se>
Created attachment 70181 [details] [review] Bug 19798: Fix print transfer slip ... and maybe other bugs as well What happens here is that $itemnumber is no longer set when barcode is passed. Test plan: 1. Check in available/not on hold item at a non owning library. 2. Click print slip 3. Item's info must be displayed on the slip Signed-off-by: Björn Nylén <bjorn.nylen@ub.lu.se> Signed-off-by: Björn Nylén <bjorn.nylen@ub.lu.se> Signed-off-by: Jon Knight <J.P.Knight@lboro.ac.uk>
Created attachment 70198 [details] [review] Bug 19798: Fix print transfer slip ... and maybe other bugs as well What happens here is that $itemnumber is no longer set when barcode is passed. Test plan: 1. Check in available/not on hold item at a non owning library. 2. Click print slip 3. Item's info must be displayed on the slip Signed-off-by: Björn Nylén <bjorn.nylen@ub.lu.se> Signed-off-by: Björn Nylén <bjorn.nylen@ub.lu.se> Signed-off-by: Jon Knight <J.P.Knight@lboro.ac.uk> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 18.05, thanks to everybody involved!
Awesome work all, pushed to stable for 17.11.02
Bug 18276 not in 17.05.x