With IntranetCatalogSearchPulldown and IntranetNumbersPreferPhrase enabled. Doing a search in the intranet from the search pulldown for the call number searches "callnum,wrdl: foobar". But it should search "callnum,phr: foobar" === Going further === It's very likely to also affect the OPAC
Created attachment 69782 [details] [review] Bug 19807: Make IntranetCatalogSearchPulldown honor IntranetNumbersPreferPhrase This patch - fixes callnum and sn - Removes unecessary syspref transmission to the template. As the template directly reads the syspref Test plan: 1. Set sysprefs IntranetCatalogSearchPulldown and IntranetNumbersPreferPhrase to true 2. Go to staff:/cgi-bin/koha/catalogue/search.pl 3. "search for" → "call number" and write anything that won't match a call number in the field 4. Then you should see «No results match your search for 'callnum,phr: [...]» 5. Go to the staff homepage 6. Click on "Search the catalog" 7. Do the same search as previouly 8. Then you should see «No results match your search for 'callnum,wrdl: [...]» This shows that IntranetNumbersPreferPhrase isn't honored 9. Apply this patch 10. Redo the same two searches and see that phr will now be always used. So IntranetNumbersPreferPhrase is honored
Created attachment 70180 [details] [review] Bug 19807: Make IntranetCatalogSearchPulldown honor IntranetNumbersPreferPhrase This patch - fixes callnum and sn - Removes unecessary syspref transmission to the template. As the template directly reads the syspref Test plan: 1. Set sysprefs IntranetCatalogSearchPulldown and IntranetNumbersPreferPhrase to true 2. Go to staff:/cgi-bin/koha/catalogue/search.pl 3. "search for" → "call number" and write anything that won't match a call number in the field 4. Then you should see «No results match your search for 'callnum,phr: [...]» 5. Go to the staff homepage 6. Click on "Search the catalog" 7. Do the same search as previouly 8. Then you should see «No results match your search for 'callnum,wrdl: [...]» This shows that IntranetNumbersPreferPhrase isn't honored 9. Apply this patch 10. Redo the same two searches and see that phr will now be always used. So IntranetNumbersPreferPhrase is honored Signed-off-by: Jon Knight <J.P.Knight@lboro.ac.uk>
Created attachment 70197 [details] [review] Bug 19807: Make IntranetCatalogSearchPulldown honor IntranetNumbersPreferPhrase This patch - fixes callnum and sn - Removes unecessary syspref transmission to the template. As the template directly reads the syspref Test plan: 1. Set sysprefs IntranetCatalogSearchPulldown and IntranetNumbersPreferPhrase to true 2. Go to staff:/cgi-bin/koha/catalogue/search.pl 3. "search for" → "call number" and write anything that won't match a call number in the field 4. Then you should see «No results match your search for 'callnum,phr: [...]» 5. Go to the staff homepage 6. Click on "Search the catalog" 7. Do the same search as previouly 8. Then you should see «No results match your search for 'callnum,wrdl: [...]» This shows that IntranetNumbersPreferPhrase isn't honored 9. Apply this patch 10. Redo the same two searches and see that phr will now be always used. So IntranetNumbersPreferPhrase is honored Signed-off-by: Jon Knight <J.P.Knight@lboro.ac.uk> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
I do not recreate the bug, and I do not understand the fix. Could you detail please? (In reply to Victor Grousset/tuxayo from comment #0) > It's very likely to also affect the OPAC Does it?
It doesn't effect the OPAC from what I could tell when testing. It just switches the indexes in the new search options pull down on the simple search according to the pref from ,wrdl to ,phr for callnumber, copying the existing behaviour for advanced search.
Note to myself: the variable is not sent from all the scripts that include search_indexes.inc. Pushed to master for 18.05, thanks to everybody involved!
Awesome work all, pushed to stable for 17.11.02
Pushed to 17.05.x for v17.05.08