In this screen /cgi-bin/koha/members/moremember.pl? I have several li tags html without id. So when I want custom the labels with the preference system 'intranetuserjs', i can't... from the record patron (memberentry.pl)...it is possible ....
Hi, you can still change the labels, but it's not as easy. Try using :contains('...') on the page with the text of the label. But using ids would make this easier - marking this patch for Academy.
*** Bug 19416 has been marked as a duplicate of this bug. ***
Created attachment 70540 [details] [review] Bug 19818: Added id's to the li tags for labels To test: 1)Go to the screen: /cgi-bin/koha/members/moremember.pl 2)On the right of the screen, right click one of the labels below 'Library use' etc, and Inspect Element 3) View <li> tags which should now each have a unique <id> tag for each
Created attachment 70555 [details] [review] Bug 19818: Added id's to the li tags for labels To test: 1)Go to the screen: /cgi-bin/koha/members/moremember.pl 2)On the right of the screen, right click one of the labels below 'Library use' etc, and Inspect Element 3) View <li> tags which should now each have a unique <id> tag for each Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de>
Looking good, just a small isuue: the spaces need to be used for indentation, not tabs. QA tool reports: FAIL koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt FAIL forbidden patterns forbidden pattern: tab char (line 495) forbidden pattern: tab char (line 492) forbidden pattern: tab char (line 396)
Created attachment 70641 [details] [review] Bug 19818: Fixing forbidden pattern by using spaces rather than tabs for indentation on lines 396, 492 & 495 in koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt
Hi, after discussing with delaye, can I add a patch with following changes? (except if for {learning, fun, wanting this bug to be finished quickly} reasons someone else wants to do it) 1. Change some of the new ids, e.g. #surname → #alt-contact-surname To add more semantic and avoid id collisions. Mosty in #patron-alternative-contact 2. #borrowernumber → #library-use-borrowernumber #borrowernumber is already used in «Upload patron image» 3. #zip/postalcode → #zip-postal-code / are valid in HTML but will be a pain when using selectors in CSS or JavaScript https://stackoverflow.com/questions/27255591/using-forward-slash-as-id-attribute#27256827 4. In #patron-alternate-address add ids, this section was forgotten. The trap was that me must fill all the field when editing the patron to ensure that they are displayed in the profile. 5. Add ids to the <li>s of #patron-information
Can I continue the work on this bug?
Hi Victor, I think it's safe to take this one, if you want to. Please make your changes in a follow-up.
Created attachment 84040 [details] [review] Bug 19818: Added appropriate id to all the list items under libary use heading. 1) Go to the patron details for a patron 2) On the right of the screen, right click one of the labels below 'Library use' etc, and Inspect Element 3) View <li> tags which should now each have a unique <id> tag for each
It looks like the codebase changed a bit since the patch was written. There is a conflict now in moremember.tt. Can you please rebase?
Created attachment 84103 [details] [review] Bug 19818: Added appropriate id to all the list items under libary use heading. 1) Go to the patron details for a patron 2) On the right of the screen, right click one of the labels below 'Library use' etc, and Inspect Element 3) View <li> tags which should now each have a unique <id> tag for each
(In reply to Katrin Fischer from comment #11) > It looks like the codebase changed a bit since the patch was written. There > is a conflict now in moremember.tt. Can you please rebase? Helene is your patch supposed to be applied on master with or without the patches already on this bug? The older patches don't apply now. The best way to approach this might be to obsolete the older patches and re-implement their changes on master.
Created attachment 84111 [details] [review] Bug 19818: Thanks, this patch should work.
Created attachment 84146 [details] [review] Bug 19818: Add id into tag html from moremember.tt 1) Go to the patron details for a patron 2) On the right of the screen, right click one of the labels below 'Library use' etc, and Inspect Element 3) View <li> tags which should now each have a unique <id> tag for each Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 84239 [details] [review] Bug 19818: Add id into tag html from moremember.tt 1) Go to the patron details for a patron 2) On the right of the screen, right click one of the labels below 'Library use' etc, and Inspect Element 3) View <li> tags which should now each have a unique <id> tag for each Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Awesome work all! Pushed to master for 19.05
Pushed to 18.11.x for 18.11.03
Merge conflict with 18.05.x. Please rebase if needed in 18.05.x.