Causing a string to become untranslatable again. This is the first attachment that reverted the relevant part of bug 16621 See the first part of the diff. https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53252&action=diff
Created attachment 70070 [details] [review] Bug 19849: Minor fixes & refactor of opac-reserve.tt & opac-user.tt - make next patch easely reviewable. - fix lone quote. (Replace by <strong> - add forgotten condition for 9999-12-31
Created attachment 70071 [details] [review] Bug 19849: Make a string translatable again after a rebase error Bug 16621 reverted part of bug 12509 1. Log in the OPAC and staff interface 2. Restrict the user logged in the OPAC (restricting yourself works) Staff interface → Patron page → Restrictions → Add manual restriction Put this comment the "OVERDUES_PROCESS Give the books back or we're comming!" 3. Install the fr_FR locale and switch the interface to it 4. Go to OPAC: /cgi-bin/koha/opac-user.pl 5. Then you should see the ugly comment with "OVERDUES_PROCESS" 6. Apply this patch 7. Update the translation: ./translate update or equivalent 8. Open misc/translator/po/fr-FR-opac-bootstrap.po 9. Find the string containing "Restriction added by overdues process" 10. Remove the fuzzy flag 11. Install the language 12. Refresh the page in the OPAC 13. Then you should see the translation + the comment instead of "OVERDUES_PROCESS" + the comment
Created attachment 76650 [details] [review] Bug 19849: Minor fixes & refactor of opac-reserve.tt & opac-user.tt - make next patch easely reviewable. - fix lone quote. (Replace by <strong> - add forgotten condition for 9999-12-31 Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 76651 [details] [review] Bug 19849: Make a string translatable again after a rebase error Bug 16621 reverted part of bug 12509 1. Log in the OPAC and staff interface 2. Restrict the user logged in the OPAC (restricting yourself works) Staff interface → Patron page → Restrictions → Add manual restriction Put this comment the "OVERDUES_PROCESS Give the books back or we're comming!" 3. Install the fr_FR locale and switch the interface to it 4. Go to OPAC: /cgi-bin/koha/opac-user.pl 5. Then you should see the ugly comment with "OVERDUES_PROCESS" 6. Apply this patch 7. Update the translation: ./translate update or equivalent 8. Open misc/translator/po/fr-FR-opac-bootstrap.po 9. Find the string containing "Restriction added by overdues process" 10. Remove the fuzzy flag 11. Install the language 12. Refresh the page in the OPAC 13. Then you should see the translation + the comment instead of "OVERDUES_PROCESS" + the comment Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 76719 [details] [review] Bug 19849: Minor fixes & refactor of opac-reserve.tt & opac-user.tt - make next patch easely reviewable. - fix lone quote. (Replace by <strong> - add forgotten condition for 9999-12-31 Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 76720 [details] [review] Bug 19849: Make a string translatable again after a rebase error Bug 16621 reverted part of bug 12509 1. Log in the OPAC and staff interface 2. Restrict the user logged in the OPAC (restricting yourself works) Staff interface → Patron page → Restrictions → Add manual restriction Put this comment the "OVERDUES_PROCESS Give the books back or we're comming!" 3. Install the fr_FR locale and switch the interface to it 4. Go to OPAC: /cgi-bin/koha/opac-user.pl 5. Then you should see the ugly comment with "OVERDUES_PROCESS" 6. Apply this patch 7. Update the translation: ./translate update or equivalent 8. Open misc/translator/po/fr-FR-opac-bootstrap.po 9. Find the string containing "Restriction added by overdues process" 10. Remove the fuzzy flag 11. Install the language 12. Refresh the page in the OPAC 13. Then you should see the translation + the comment instead of "OVERDUES_PROCESS" + the comment Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Awesome work all! Pushed to master for 18.11
Pushed to 18.05.x for 18.05.02
Pushed to 17.11.x for 17.11.08