Use styling from tools sidebar for reports sidebar as well.
Created attachment 70543 [details] [review] Bug 19856: Improve styling of reports sidebar Test Plan 1. Open tools page and click on any of the links with a sidebar 2. Note the layout of the sidebar 3. Open reports page and click on any of the links with a sidebar 4. All the sidebars should have the same layout as the tools one
Created attachment 70554 [details] [review] Bug 19856: Improve styling of reports sidebar Test Plan 1. Open tools page and click on any of the links with a sidebar 2. Note the layout of the sidebar 3. Open reports page and click on any of the links with a sidebar 4. All the sidebars should have the same layout as the tools one Signed-off-by: Owen Leonard <oleonard@myacpl.org>
With this patch, it only worsk for guided reports. You should also change the file reports-menu.inc, to get this working on any of reports with sidebar.
Created attachment 70642 [details] [review] Bug 19856: Improve styling of reports sidebar Added divs to report-menu.inc as well. Should work on any reports page with sidebar now.
I don't know if it was an innocuous mistake, but the first patch modified guided-reports-view.inc, and now the only available patch on this bug changes reports-menu.inc instead. From what I read, Josef suggested _adding_ another patch, not replacing it altogether.
Patch tested with a sandbox, by claude <claude.brayer@cea.fr>
Created attachment 72674 [details] [review] Bug 19856: Improve styling of reports sidebar Added divs to report-menu.inc as well. Should work on any reports page with sidebar now. Signed-off-by: claude <claude.brayer@cea.fr>
Created attachment 73074 [details] [review] Bug 19856: Improve styling of reports sidebar Test Plan 1. Open tools page and click on any of the links with a sidebar 2. Note the layout of the sidebar 3. Open reports page and click on any of the links with a sidebar 4. All the sidebars should have the same layout as the tools one Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 73075 [details] [review] Bug 19856: Improve styling of reports sidebar Added divs to report-menu.inc as well. Should work on any reports page with sidebar now. Signed-off-by: claude <claude.brayer@cea.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
I unobsoleted the first patch, both have been signed off separately, so I didn't squash them. Together they create a complete fix.
Pushed to master for 18.05, thanks to everybody involved!
Enhancement, not backported for 17.11