Bug 19902 - Add column configuration to bibliographic record checkouts history table
Summary: Add column configuration to bibliographic record checkouts history table
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff interface (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Josef Moravec
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks: 19282
  Show dependency treegraph
 
Reported: 2018-01-02 07:11 UTC by Josef Moravec
Modified: 2020-01-06 20:14 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 19902: Add column settings to bibliographic record checkouts history table (3.01 KB, patch)
2018-01-02 07:46 UTC, Josef Moravec
Details | Diff | Splinter Review
Bug 19902: Add column settings to bibliographic record checkouts history table (3.09 KB, patch)
2018-05-29 18:28 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 19902: (follow-up) Deal with patron column regarding on intranetreadinghistory setting (2.46 KB, patch)
2018-06-25 11:30 UTC, Josef Moravec
Details | Diff | Splinter Review
Bug 19902: Add column settings to bibliographic record checkouts history table (3.18 KB, patch)
2018-06-25 21:05 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 19902: (follow-up) Deal with patron column regarding on intranetreadinghistory setting (2.54 KB, patch)
2018-06-25 21:05 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Josef Moravec 2018-01-02 07:11:24 UTC

    
Comment 1 Josef Moravec 2018-01-02 07:46:44 UTC
Created attachment 70220 [details] [review]
Bug 19902: Add column settings to bibliographic record checkouts history table

Test plan:
0) Apply the patch
1) Go to administration -> Configure columns, note there is new
checkoutshistory-table in Catalogue section
2) Make some configuration in this table settings
3) Go to detail of any record -> Checkout history
4) The columns should be visible according to your configuration from
step 2
5) Play with Column visibility, to ensure it does work as it should
Comment 2 jmbroust 2018-03-12 11:52:20 UTC
I did not succeed in hiding any column of the table.
I tried on other tables (example check in table) and it worked fine so I think it is trully a problem with this patch.
Comment 3 Owen Leonard 2018-05-29 18:28:55 UTC
Created attachment 75642 [details] [review]
Bug 19902: Add column settings to bibliographic record checkouts history table

Test plan:
0) Apply the patch
1) Go to administration -> Configure columns, note there is new
checkoutshistory-table in Catalogue section
2) Make some configuration in this table settings
3) Go to detail of any record -> Checkout history
4) The columns should be visible according to your configuration from
step 2
5) Play with Column visibility, to ensure it does work as it should

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Fixed a minor typo during signoff.
Comment 4 Jonathan Druart 2018-05-30 19:45:44 UTC
Turn off intranetreadinghistory
=> boom!
Comment 5 Josef Moravec 2018-06-25 11:30:24 UTC
Created attachment 76369 [details] [review]
Bug 19902: (follow-up) Deal with patron column regarding on intranetreadinghistory setting

Test plan:
Try it with intranetreadinghistory allowed and not allowed and it should
still work in both cases
Comment 6 Josef Moravec 2018-06-25 11:30:59 UTC
(In reply to Jonathan Druart from comment #4)
> Turn off intranetreadinghistory
> => boom!

Thanks for catching this!
Comment 7 Jonathan Druart 2018-06-25 21:05:30 UTC
Created attachment 76420 [details] [review]
Bug 19902: Add column settings to bibliographic record checkouts history table

Test plan:
0) Apply the patch
1) Go to administration -> Configure columns, note there is new
checkoutshistory-table in Catalogue section
2) Make some configuration in this table settings
3) Go to detail of any record -> Checkout history
4) The columns should be visible according to your configuration from
step 2
5) Play with Column visibility, to ensure it does work as it should

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Fixed a minor typo during signoff.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 8 Jonathan Druart 2018-06-25 21:05:36 UTC
Created attachment 76421 [details] [review]
Bug 19902: (follow-up) Deal with patron column regarding on intranetreadinghistory setting

Test plan:
Try it with intranetreadinghistory allowed and not allowed and it should
still work in both cases

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 9 Nick Clemens 2018-07-18 19:15:46 UTC
Awesome work all!

Pushed to master for 18.11
Comment 10 Martin Renvoize 2018-08-02 12:20:29 UTC
Enhancement, will not be backported to 18.05.x series.