Created attachment 70337 [details] [review] Bug 19929 - Add Koha objects for class sources and sorters prove -v t/db_dependent/Koha/ClassificationSorters.t prove -v t/db_dependent/Koha/ClassificationSources.t
The full word "Classification" makes the file name to DB file in the head without reading and without consulting schema harder. ClassSortRule and ClassSortRules would be nicer than ClassificationSort and ClassificationSorters, I think.
Comment on attachment 70337 [details] [review] Bug 19929 - Add Koha objects for class sources and sorters Review of attachment 70337 [details] [review]: ----------------------------------------------------------------- ::: Koha/ClassificationSorters.pm @@ +20,5 @@ > +use Carp; > + > +use Koha::Database; > + > +use Koha::ClassificationSorters; It uses itself? Don't think this is correct.
Created attachment 72948 [details] [review] Bug 19929 - Add Koha objects for class sources and sorters prove -v t/db_dependent/Koha/ClassSortRules.t prove -v t/db_dependent/Koha/ClassSources.t
Created attachment 72949 [details] [review] Bug 19929 - Add Koha objects for class sources and sorters prove -v t/db_dependent/Koha/ClassSortRules.t prove -v t/db_dependent/Koha/ClassSources.t
Created attachment 72959 [details] [review] Bug 19929 - Add Koha objects for class sources and sorters prove -v t/db_dependent/Koha/ClassSortRules.t prove -v t/db_dependent/Koha/ClassSources.t NOTE: No POD was added, but I don't believe it is mandatory. PERL13 says it is only encouraged, not required. Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
QA: Working here
Created attachment 72965 [details] [review] Bug 19929 - Add Koha objects for class sources and sorters prove -v t/db_dependent/Koha/ClassSortRules.t prove -v t/db_dependent/Koha/ClassSources.t Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 72966 [details] [review] Bug 19929: (QA follow-up) Fix POD Make qa tools happy. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Pushed to master for 18.05, thanks to everybody involved!
Enhancement, not backported for 17.11