This bug falls under the omnibus Bug 19931, "Update popup window templates to use Bootstrap grid." Updated in this patch will be z3950_search.tt, the template for Z39.50 searches from the cataloging interface.
Created attachment 70341 [details] [review] Bug 19932: Update popup window templates to use Bootstrap grid: Cataloging Z39.50 search This patch updates the cataloging Z39.50 search template to use the Bootstrap grid instead of the YUI grid. Also fixed: Several un-quoted HTML attributes have been corrected. To test, apply the patch and go to Cataloging -> New from Z39.50/SRU. In the popup window, both the search form and search results pages should look correct.
Created attachment 70713 [details] [review] Bug 19932: Update popup window templates to use Bootstrap grid: Cataloging Z39.50 search This patch updates the cataloging Z39.50 search template to use the Bootstrap grid instead of the YUI grid. Also fixed: Several un-quoted HTML attributes have been corrected. To test, apply the patch and go to Cataloging -> New from Z39.50/SRU. In the popup window, both the search form and search results pages should look correct. Signed-off-by: Zoe Bennett <zoebennett1308@gmail.com>
With the patch the save/cancel options are outside of the visible area. (Firefox Quantum 58 on Ubuntu). Without the patch it's ok. Could you take another look? Everything else seems to work perfectly.
Created attachment 71284 [details] [review] Bug 19932: (Follow-up) Add fixed footer to cataloging Z39.50 popup This patch adds additional Bootstrap framework markup to the search form so that the "Save" and "Cancel" controls are in a fixed footer at the bottom of the window. This prevents the controls from disappearing down off screen. To test, apply the patch and go to Cataloging -> New from Z39.50/SRU. In the popup window, both the search form and search results pages should look correct.
Created attachment 71334 [details] [review] [SIGNED-OFF] Bug 19932: Update popup window templates to use Bootstrap grid: Cataloging Z39.50 search This patch updates the cataloging Z39.50 search template to use the Bootstrap grid instead of the YUI grid. Also fixed: Several un-quoted HTML attributes have been corrected. To test, apply the patch and go to Cataloging -> New from Z39.50/SRU. In the popup window, both the search form and search results pages should look correct. Signed-off-by: Zoe Bennett <zoebennett1308@gmail.com> Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de>
Created attachment 71335 [details] [review] [SIGNED-OFF] Bug 19932: (Follow-up) Add fixed footer to cataloging Z39.50 popup This patch adds additional Bootstrap framework markup to the search form so that the "Save" and "Cancel" controls are in a fixed footer at the bottom of the window. This prevents the controls from disappearing down off screen. To test, apply the patch and go to Cataloging -> New from Z39.50/SRU. In the popup window, both the search form and search results pages should look correct. Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de>
Created attachment 71700 [details] [review] Bug 19932: Update popup window templates to use Bootstrap grid: Cataloging Z39.50 search This patch updates the cataloging Z39.50 search template to use the Bootstrap grid instead of the YUI grid. Also fixed: Several un-quoted HTML attributes have been corrected. To test, apply the patch and go to Cataloging -> New from Z39.50/SRU. In the popup window, both the search form and search results pages should look correct. Signed-off-by: Zoe Bennett <zoebennett1308@gmail.com> Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 71701 [details] [review] Bug 19932: (follow-up) Add fixed footer to cataloging Z39.50 popup This patch adds additional Bootstrap framework markup to the search form so that the "Save" and "Cancel" controls are in a fixed footer at the bottom of the window. This prevents the controls from disappearing down off screen. To test, apply the patch and go to Cataloging -> New from Z39.50/SRU. In the popup window, both the search form and search results pages should look correct. Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 18.05, thanks to everybody involved!