sudo koha-shell -c bash kohadev prove t/db_dependent/www/batch.t cat /var/log/koha/kohadev/plack-error.log The following errors are triggered: Use of uninitialized value in array element at /home/vagrant/kohaclone/tools/batch_records_ajax.pl line 50. Use of uninitialized value $results_per_page in numeric eq (==) at /home/vagrant/kohaclone/tools/batch_records_ajax.pl line 53. Use of uninitialized value in uc at /home/vagrant/kohaclone/C4/ImportBatch.pm line 1120.
Created attachment 70364 [details] [review] Bug 19937: Silence warnings t/db_dependent/www/batch.t TEST PLAN --------- 1) Run the following on a kohadevbox: git checkout -b bug_19937 origin/master sudo koha-shell -c bash kohadev prove t/db_dependent/www/batch.t cat /var/log/koha/kohadev/plack-error.log The following errors are triggered at the end of the log file: Use of uninitialized value in array element at /home/vagrant/kohaclone/tools/batch_records_ajax.pl line 50. Use of uninitialized value $results_per_page in numeric eq (==) at /home/vagrant/kohaclone/tools/batch_records_ajax.pl line 53. Use of uninitialized value in uc at /home/vagrant/kohaclone/C4/ImportBatch.pm line 1120. 2) Run the following on a kohadevbox: exit git bz apply 19937 restart_all sudo koha-shell -c bash kohadev prove t/db_dependent/www/batch.t cat /var/log/koha/kohadev/plack-error.log The log file will end with the restarting of plack, not the errors. 3) run koha qa test tools
Created attachment 70410 [details] [review] Bug 19937: Silence warnings t/db_dependent/www/batch.t TEST PLAN --------- 1) Run the following on a kohadevbox: git checkout -b bug_19937 origin/master sudo koha-shell -c bash kohadev prove t/db_dependent/www/batch.t cat /var/log/koha/kohadev/plack-error.log The following errors are triggered at the end of the log file: Use of uninitialized value in array element at /home/vagrant/kohaclone/tools/batch_records_ajax.pl line 50. Use of uninitialized value $results_per_page in numeric eq (==) at /home/vagrant/kohaclone/tools/batch_records_ajax.pl line 53. Use of uninitialized value in uc at /home/vagrant/kohaclone/C4/ImportBatch.pm line 1120. 2) Run the following on a kohadevbox: exit git bz apply 19937 restart_all sudo koha-shell -c bash kohadev prove t/db_dependent/www/batch.t cat /var/log/koha/kohadev/plack-error.log The log file will end with the restarting of plack, not the errors. 3) run koha qa test tools Signed-off-by: Lee Jamison <ldjamison@marywood.edu>
Created attachment 70447 [details] [review] Bug 19937: Silence warnings t/db_dependent/www/batch.t TEST PLAN --------- 1) Run the following on a kohadevbox: git checkout -b bug_19937 origin/master sudo koha-shell -c bash kohadev prove t/db_dependent/www/batch.t cat /var/log/koha/kohadev/plack-error.log The following errors are triggered at the end of the log file: Use of uninitialized value in array element at /home/vagrant/kohaclone/tools/batch_records_ajax.pl line 50. Use of uninitialized value $results_per_page in numeric eq (==) at /home/vagrant/kohaclone/tools/batch_records_ajax.pl line 53. Use of uninitialized value in uc at /home/vagrant/kohaclone/C4/ImportBatch.pm line 1120. 2) Run the following on a kohadevbox: exit git bz apply 19937 restart_all sudo koha-shell -c bash kohadev prove t/db_dependent/www/batch.t cat /var/log/koha/kohadev/plack-error.log The log file will end with the restarting of plack, not the errors. 3) run koha qa test tools Signed-off-by: Lee Jamison <ldjamison@marywood.edu> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Amended handling of $results_per_page.
Pushed to master for 18.05, thanks to everybody involved!
Awesome work all! Pushed to Stable for 17.11.02
Pushed to 17.05.x for v17.05.09